Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "invalid path" with Bazel 8 #738

Closed
mering opened this issue Nov 26, 2024 · 6 comments · Fixed by #744
Closed

Bug: "invalid path" with Bazel 8 #738

mering opened this issue Nov 26, 2024 · 6 comments · Fixed by #744

Comments

@mering
Copy link
Contributor

mering commented Nov 26, 2024

In Bazel 8, the repo paths on disk change from repo~ to repo+. This can already be tested in Bazel 7 with --incompatible_use_plus_in_repo_names (bazelbuild/bazel#23127). Similar to #588, image creation fails with

invalid reference, invalid path for scheme "ocidir": bazel-out/k8-fastbuild/bin/external/repo+/package/test-image:intermediate
@mering
Copy link
Contributor Author

mering commented Nov 27, 2024

Requires regclient/regclient#856 (merged).

@mering
Copy link
Contributor Author

mering commented Nov 28, 2024

@alexeagle could you PTAL? Thanks.

@thesayyn
Copy link
Collaborator

thesayyn commented Dec 5, 2024

We need a new version of regctl before we can fix anything here, until then the flag can be flipped to use ~ instead.

@keith
Copy link
Member

keith commented Dec 6, 2024

Note that the flag is a no-op in 8.x, so it's not possible to flip back

@sudo-bmitch
Copy link

regclient just released. Hopefully that unblocks you. https://github.com/regclient/regclient/releases/tag/v0.8.0

@thesayyn
Copy link
Collaborator

Thank you friend :)

alexeagle added a commit that referenced this issue Dec 11, 2024
Also opt-in to Bazel 8 repo naming with plus rather than tilde

Fixes #738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants