Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update bazel to 4.2 #2926

Merged
merged 1 commit into from
Jan 12, 2022
Merged

chore: update bazel to 4.2 #2926

merged 1 commit into from
Jan 12, 2022

Conversation

alexeagle
Copy link
Collaborator

It has a relevant bugfix for mac M1 toolchain discovery

@google-cla google-cla bot added the cla: yes label Sep 9, 2021
@alexeagle
Copy link
Collaborator Author

alexeagle commented Sep 13, 2021 •
edited
Loading

@gregmagolan uh oh, on RBE:



(23:20:08) ERROR: /workdir/internal/node/test/directory_artifacts_tsc/BUILD.bazel:3:4: Action internal/node/test/directory_artifacts_tsc/main.js failed: (Exit 1): tsc.sh failed: error executing command
--


ERROR[runfiles.bash]:
 cannot look up runfile 
"npm_directory_artifacts/node_modules/typescript"  
(RUNFILES_DIR="/b/f/w/bazel-out/host/bin/external/npm_directory_artifacts/typescript/bin/tsc.sh.runfiles",
 RUNFILES_MANIFEST_FILE="")

something about directory artifacts regressed in bazel 4.2?

@alexeagle
Copy link
Collaborator Author

ah, right. we saw that was coming
bazelbuild/bazel#13558 (comment)

@alexeagle
Copy link
Collaborator Author

I think this will be unblocked by #2996

@CooperBills CooperBills mentioned this pull request Nov 19, 2021
Closed
5 tasks
@alexeagle alexeagle force-pushed the update_bazel branch 2 times, most recently from cbf8d8e to c315a6d Compare January 11, 2022 18:21
@alexeagle alexeagle added this to the 5.0 milestone Jan 11, 2022
@alexeagle alexeagle force-pushed the update_bazel branch 2 times, most recently from a4eb04e to 3a5548d Compare January 11, 2022 19:37
@alexeagle alexeagle changed the title chore: update bazel to 4.2.0 chore: update bazel to 4.2 Jan 11, 2022
@google-cla google-cla bot added cla: no and removed cla: yes labels Jan 11, 2022
@alexeagle alexeagle changed the base branch from stable to 5.x January 12, 2022 00:13
@google-cla
Copy link

google-cla bot commented Jan 12, 2022

☹️ Sorry, but only Googlers may change the label cla: yes.

@google-cla google-cla bot removed the cla: yes label Jan 12, 2022
@alexeagle alexeagle merged commit ebc572b into bazel-contrib:5.x Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan is a code owner

@mattem mattem Awaiting requested review from mattem mattem is a code owner

@soldair soldair Awaiting requested review from soldair

@alan-agius4 alan-agius4 Awaiting requested review from alan-agius4

@jbedard jbedard Awaiting requested review from jbedard

@mrmeku mrmeku Awaiting requested review from mrmeku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@alexeagle