Use ctx.version_file in place of a genrule with stamp=True #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprobst
approved these changes
Mar 23, 2018
mprobst
reviewed
Mar 23, 2018
internal/npm_package/npm_package.bzl
Outdated
|
|
||
| inputs = ctx.files.srcs + devmode_sources + nested_packages + [ctx.file._run_npm_template] | ||
| if ctx.file.stamp_data: | ||
| inputs.append(ctx.file.stamp_data) | ||
| if ctx.version_file: |
There was a problem hiding this comment.
It might be worth adding a comment here, too.
alexeagle
pushed a commit
to alexeagle/rules_nodejs
that referenced
this pull request
Oct 17, 2020
Closes bazel-contrib#162 PiperOrigin-RevId: 191444855
alexeagle
pushed a commit
to alexeagle/rules_nodejs
that referenced
this pull request
Oct 18, 2020
Closes bazel-contrib#162 PiperOrigin-RevId: 191444855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156
See discussion in bazelbuild/bazel#4842
and this fix is based on bazelbuild/bazel#1054 (comment)