Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: Update rules_go version for incoming incompatible change #3387

Merged
merged 2 commits into from
Dec 7, 2022
Merged

examples: Update rules_go version for incoming incompatible change #3387

merged 2 commits into from
Dec 7, 2022

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Dec 7, 2022

Fixes #3386

@fmeum fmeum force-pushed the 3386-incompatible-config-setting-private-default-visibility branch from 6194c94 to c4caef1 Compare December 7, 2022 07:04
@fmeum fmeum mentioned this pull request Dec 7, 2022
Closed
@fmeum
Copy link
Member Author

fmeum commented Dec 7, 2022 •
edited
Loading

@chrislovecnm Had to remove a test target in a51d546 as duplicate tests break the build on Windows. Kept the one generated by gazelle.

@fmeum fmeum requested a review from linzhp December 7, 2022 18:51
@linzhp linzhp merged commit 9f76012 into master Dec 7, 2022
@linzhp linzhp deleted the 3386-incompatible-config-setting-private-default-visibility branch December 7, 2022 18:52
@chrislovecnm
Copy link
Contributor

@linzhp the test is part of the tutorial, and they are now out of sync. How can we fix this rather than removing it?

@fmeum
Copy link
Member Author

fmeum commented Dec 7, 2022 •
edited
Loading

@chrislovecnm Could you remove the test in the tutorial and maybe add a step to add it once it differs substantially from the other one? Having two go_tests with the same sources and very similar names seems like a rather confusing starting point. Plus, it makes the build flaky on Windows.

@chrislovecnm
Copy link
Contributor

@fmeum I think gazelle created the duplicate 🤔 - we do not need two tests with the same name, which was a bug not in the tutorial. Weird. So 👍 on the PR and thanks.

healthy-pod pushed a commit to cockroachdb/rules_go that referenced this pull request Feb 18, 2023
@fmeum
examples: Update rules_go version for incoming incompatible change (b…
721bd0d 
…azel-contrib#3387)
healthy-pod pushed a commit to cockroachdb/rules_go that referenced this pull request Feb 22, 2023
@fmeum
examples: Update rules_go version for incoming incompatible change (b…
1ccac68 
…azel-contrib#3387)
tingilee pushed a commit to tingilee/rules_go that referenced this pull request Jul 19, 2023
@fmeum
examples: Update rules_go version for incoming incompatible change (b…
28486d5 
…azel-contrib#3387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linzhp linzhp Awaiting requested review from linzhp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flag --incompatible_config_setting_private_default_visibility will break rules_go in Bazel 7.0
3 participants
@fmeum @chrislovecnm @linzhp