Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI config to test on RBE. #1638

Merged
merged 3 commits into from
Aug 8, 2018
Merged

Add CI config to test on RBE. #1638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9695d8
Add CI config to test on RBE.
xingao267 Aug 8, 2018
5a8016c
Disable BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN.
xingao267 Aug 8, 2018
2a3bf10
Skip tests that are not RBE compatible.
xingao267 Aug 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,18 @@ platforms:
- "..."
test_targets:
- "..."
rbe_ubuntu1604:
build_targets:
- "..."
test_flags:
# Some tests depend on this feature being disabled. However, because it's
# enabled by default in the rbe_ubuntu1604 platform, we cannot simply remove
# this flag here, we have to explicitly override it with 0.
- "--action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=0"
test_targets:
- "--"
- "..."
- "-//:vet"
- "-//tests/core/go_path:go_path_test"
- "-//tests/core/stdlib:buildid_test"
- "-@com_github_mattn_go_sqlite3//:go_default_test"
10 changes: 10 additions & 0 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
workspace(name = "io_bazel_rules_go")

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
load("@io_bazel_rules_go//go:def.bzl", "go_rules_dependencies", "go_register_toolchains")
load("@io_bazel_rules_go//proto:def.bzl", "proto_register_toolchains")

Expand Down Expand Up @@ -39,3 +40,12 @@ llvm_toolchain(
name = "llvm_toolchain",
llvm_version = "6.0.0",
)

http_archive(
name = "bazel_toolchains",
sha256 = "7938215442cc96b1a16809f4643db14af7d91c3ef1e98d39593bb46862204537",
strip_prefix = "bazel-toolchains-809c13c3a96966f63c7a43c586cb4e72589184b6",
urls = [
"https://github.com/bazelbuild/bazel-toolchains/archive/809c13c3a96966f63c7a43c586cb4e72589184b6.tar.gz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we pin them to the latest release instead of this commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do that in a separate PR.

],
)