Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlib now uses precompiled libraries if the mode is compatible #1608

Merged
merged 5 commits into from
Jul 27, 2018
Merged

stdlib now uses precompiled libraries if the mode is compatible #1608

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e54eab1
Add go_sdk rule and GoSDK provider
Jul 25, 2018
37ef9c9
Wire go_sdk and go_toolchain together
Jul 25, 2018
3a68094
Merge branch 'master' into wire-sdk-toolchain
Jul 26, 2018
2b60585
stdlib now uses precompiled libraries if the mode is compatible
Jul 25, 2018
1e55b06
Merge branch 'master' into precompiled-stdlib
Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion go/private/rules/stdlib.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,31 @@ load(
"@io_bazel_rules_go//go/private:mode.bzl",
"LINKMODE_C_ARCHIVE",
"LINKMODE_C_SHARED",
"LINKMODE_NORMAL",
"LINKMODE_PLUGIN",
)

def _stdlib_library_to_source(go, attr, source, merge):
if _should_use_sdk_stdlib(go):
source["stdlib"] = _sdk_stdlib(go)
else:
source["stdlib"] = _build_stdlib(go, attr)

def _should_use_sdk_stdlib(go):
return (go.mode.goos == go.sdk.goos and
go.mode.goarch == go.sdk.goarch and
not go.mode.race and # TODO(jayconrod): use precompiled race
not go.mode.msan and
not go.mode.pure and
go.mode.link == LINKMODE_NORMAL)

def _sdk_stdlib(go):
return GoStdLib(
root_file = go.sdk.root_file,
libs = go.sdk.libs,
)

def _build_stdlib(go, attr):
pkg = go.declare_directory(go, "pkg")
src = go.declare_directory(go, "src")
root_file = go.declare_file(go, "ROOT")
Expand Down Expand Up @@ -67,7 +88,7 @@ def _stdlib_library_to_source(go, attr, source, merge):
arguments = [args],
env = env,
)
source["stdlib"] = GoStdLib(
return GoStdLib(
root_file = root_file,
libs = [pkg],
)
Expand Down