-
-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implicit inconsistent import of status.proto for go and gRPC #1530
Comments
This conflict is happening because the I don't have a simple workaround to offer for this. We need to extract all the |
I've got a lousy workaround - in my explicit go_proto_library rule, use a non-standard importpath, so Go sees them as different entities. |
I cloud workaround this by fixing vendored dependencies version to go_rules' dependencies version written here. |
This should be working now with the changes related to #1548. Please try rules_go and Gazelle 0.13.0 when they are tagged in the next day or two (or try |
Use Go proto libraries exported from cel-spec. Note that we use a different Go package for the google.rpc.Status message than is specified in its .proto file. We do this to avoid a different and incompatible Go proto library that is brought in by the Bazel rules. We will revert to the right package when this bug is fixed. See bazel-contrib/rules_go#1530 Expand common.Source to subsume interpreter.Metadata, for the latter's eventual deprecation, and to allow the checker inputs to be constructed without access to the source text. Introduce a specialized traits.Lister for arrays of ref.Value values. Implement CelService server and tests. Includes conversion between ref.Value types and protos.
CelService server for cel-go. Use Go proto libraries exported from cel-spec. Note that we use a different Go package for the google.rpc.Status message than is specified in its .proto file. We do this to avoid a different and incompatible Go proto library that is brought in by the Bazel rules. We will revert to the right package when this bug is fixed. See bazel-contrib/rules_go#1530 Expand common.Source to subsume interpreter.Metadata, for the latter's eventual deprecation, and to allow the checker inputs to be constructed without access to the source text. Introduce a specialized traits.Lister for arrays of ref.Value values. Implement CelService server and tests. Includes conversion between ref.Value types and protos.
Bazel + Go + gRPC still doesn't work, but leaving this closed as the current problem is covered by another issue: pubref/rules_protobuf#237 |
When I attempt to use a proto used by the gRPC implementation in my gRPC service, I get a link error from inconsistent versions of the compiled golang library. In this case, I'm attempting to use the
Status
message fromgithub.com/googleapis/googleapis/google/rpc/status.proto
in my application-level protocol.Please see the following for the code: https://github.com/JimLarson/repro1/tree/70ef7482daf017a356156e495e1eb150f3f1f81b
Running "bazel build ..." results in:
I previously had problems getting the proto using Status to compile. A workaround is applied in commit number 2. (6fa7ba8a6a542feb34245e119a02c40f6c71d8e8).
See also issue 1445?
The text was updated successfully, but these errors were encountered: