Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logic that finds child workspaces to include the new workspace marker files. #272

Closed
cgrindel opened this issue Jan 14, 2024 · 3 comments · Fixed by #278
Closed

Update logic that finds child workspaces to include the new workspace marker files. #272

cgrindel opened this issue Jan 14, 2024 · 3 comments · Fixed by #278
Assignees
@cgrindel
Labels
enhancement New feature or request

Comments

@cgrindel
Copy link
Member

cgrindel commented Jan 14, 2024 •
edited
Loading

New workspace maker files:

  • REPO.bazel
  • MODULE.bazel

The list needs to be confirmed with the community.
@cgrindel cgrindel added the enhancement New feature or request label Jan 14, 2024
@cgrindel cgrindel mentioned this issue Jan 14, 2024
Merged
@cgrindel
Copy link
Member Author

Tracking issue for REPO.bazel
Design doc for REPO.bazel

@cgrindel
Copy link
Member Author

Quote from the design doc:

When looking for a repository root, we treat any of REPO.bazel, MODULE.bazel, and WORKSPACE[.bazel] as a repo sentinel.

@cgrindel
Copy link
Member Author

Slack thread confirming the list of repo sentinels

@cgrindel cgrindel self-assigned this Jan 14, 2024
@cgrindel cgrindel mentioned this issue Jan 21, 2024
Merged
cgrindel added a commit that referenced this issue Jan 22, 2024
@cgrindel
chore: add REPO.bazel and MODULE.bazel as workspace sentinels (#278)
79b50cf 
- Refactored common file find logic to `find_any_file`.
- Add `REPO.bazel` and `MODULE.bazel` to the list of workspace
sentinels.
- Add unit test for `find_workspace_dirs`.

[Docuementation](https://bazel.build/external/overview#repository)
Closes #272.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgrindel cgrindel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@cgrindel