Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature to test whether Stardoc support module extensions. #34

Closed
wants to merge 1 commit into from

Conversation

phst
Copy link
Contributor

@phst phst commented Jan 17, 2024

Copy link
Member

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate on the use case for this? Since stardoc targets are typically built in the module in which they are defined and the support also depends on the stardoc version, I'm not sure whether a feature is the best way to support it.

@phst
Copy link
Contributor Author

phst commented Jan 17, 2024

In https://github.com/phst/rules_elisp/blob/8606695e977b876ffb38f881f54e50de1606a733/docs/BUILD I selectively build the extensions target (for a Starlark file containing module extensions) depending on whether the current Bazel version is 7 or not. Whether this works or not appears to depend mainly on the Bazel version, at least for recent enough Stardoc versions. Happy to switch to a better approach if there's one!

@fmeum
Copy link
Member

fmeum commented Jan 17, 2024

There is, you can detect the required Bazel feature directly: https://github.com/bazelbuild/stardoc/blob/bf441c86274770ea281d21e22292ecdaa6451eaa/stardoc/stardoc.bzl#L88

Let me know if that doesn't work and we can reconsider this.

@phst
Copy link
Contributor Author

phst commented Jan 18, 2024

It works, thanks!
phst/rules_elisp@5778796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants