This repository has been archived by the owner on Feb 10, 2025. It is now read-only.
[PD-257044] databus changes rebase #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharadwaj-k
approved these changes
Nov 5, 2024
nabajyotiDash-hub
added a commit
that referenced
this pull request
Nov 6, 2024
* feat: execution name sanitization and unit test for stepfn * master_size api changes * Admin API changes (#845) 1. /UpdateParameterStore 2. /QueueExecutionAttributes/<queue_type>/<queue_name> * PD-257044-changes-for-databus (#846) * added datadog metrics changes * [PD-257044] databus changes rebase (#848) * PD-257044-changes-for-databus * duplicated kafka and ssm util packages in emo sor module * removed redundant dependencies * admin api and queue name split * Pd 257044 databus changes rebase (#849) * PD-257044-changes-for-databus * duplicated kafka and ssm util packages in emo sor module * removed redundant dependencies * additional changes * additional changes * additional changes * removed unneccessary dependencies * Revert "added datadog metrics changes" This reverts commit 62dc31e. * build fix * endpoint change and databus changes * updated updateRefInDatabus method * address review commnets * branch admin -prepare release emodb-6.5.205 * branch admin -prepare for next development iteration --------- Co-authored-by: Rishu Yadav <rishu.yadav@bazaarvoice.com> Co-authored-by: shanmohammed-bv <ntyshaan@gmail.com> Co-authored-by: Anurag Dubey <anurag.dubey@bazaarvoice.com> Co-authored-by: Anandu Jayan <anandu.jayan@bazaarvoice.com> Co-authored-by: jenkins <bv-jenkins@bazaarvoice.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue
1234
What Are We Doing Here?
Here is where you should describe the problem you are solving as it relates to the Github Issue referred above, adding any fine
details on the solution that might otherwise not be recognizable for someone
unfamiliar with the changes. Add some pictures if it helps.
How to Test and Verify
Risk
Level
Low,Medium, orHigh. Give an indication of what you think is the level of change introduced by this PR.Highmeans a massive change to a core functionality.Lowmeans a really minor change that shouldn't have any regression effect.Required Testing
Smoke,Regression, orManual. (All changes except documentation need smoketesting at a minimum).
Risk Summary
Add one or a few complete sentences about the possible risks or concerns for
this change.
Code Review Checklist
Tests are included. If not, make sure you leave us a line or two for the reason.
Pulled down the PR and performed verification of at least being able to
build and run.
Well documented, including updates to any necessary markdown files. When
we inevitably come back to this code it will only take hours to figure out, not
days.
Consistent/Clear/Thoughtful? We are better with this code. We also aren't
a victim of rampaging consistency, and should be using this course of action.
We don't have coding standards out yet for this project, so please make sure to address any feedback regarding STYLE so the codebase remains consistent.
PR has a valid summary, and a good description.