Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port as an argument to session #918

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

progwriter
Copy link
Contributor

Add port param, prefer it over port_v2, but keep the latter for backwards compatibility

Fixes #917

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @progwriter)


tests/client/test_session.py line 104 at r1 (raw file):

def test_port_set():
    s = Session(api_key="foo", port=8888, load_questions=False)
    assert s.port_v2 == 8888

Nit: Can you also set port_v2 here to prove priority?

Copy link
Contributor Author

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @arifogel)


tests/client/test_session.py line 104 at r1 (raw file):

Previously, arifogel (Ari Fogel) wrote…

Nit: Can you also set port_v2 here to prove priority?

done

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @progwriter)

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @progwriter)

@progwriter progwriter merged commit 28f8e08 into batfish:master Jul 22, 2024
16 checks passed
@progwriter progwriter deleted the default-port branch July 22, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the Session port key to port instead of port_v2
3 participants