Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urllib3: upgrade to allowed_methods #882

Merged
merged 1 commit into from
May 6, 2023
Merged

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented May 5, 2023

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #882 (adae5dc) into master (26aee45) will not change coverage.
The diff coverage is n/a.

❗ Current head adae5dc differs from pull request most recent head 3eafc7c. Consider uploading reports for the commit 3eafc7c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #882   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          30       30           
  Lines        3992     3992           
  Branches      665      665           
=======================================
  Hits         3433     3433           
  Misses        412      412           
  Partials      147      147           
Impacted Files Coverage Δ
pybatfish/client/_diagnostics.py 74.31% <ø> (ø)
pybatfish/client/resthelper.py 47.72% <ø> (ø)
pybatfish/client/restv2helper.py 70.52% <ø> (ø)

@dhalperi dhalperi merged commit 74a873a into master May 6, 2023
@dhalperi dhalperi deleted the pr/dhalperi/master/ae5f43f3 branch May 6, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants