Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session: flip enable_diagnostics to False #880

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Feb 22, 2023

Stop advertising this functionality.

commit-id:dbbb939f

Stop advertising this functionality.

commit-id:dbbb939f
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #880 (3e8b0d6) into master (8e9adb5) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head 3e8b0d6 differs from pull request most recent head 7c7fa42. Consider uploading reports for the commit 7c7fa42 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #880      +/-   ##
==========================================
- Coverage   86.12%   85.99%   -0.13%     
==========================================
  Files          30       30              
  Lines        3992     3992              
  Branches      665      665              
==========================================
- Hits         3438     3433       -5     
- Misses        406      412       +6     
+ Partials      148      147       -1     
Impacted Files Coverage Δ
pybatfish/client/session.py 75.75% <100.00%> (-0.24%) ⬇️
pybatfish/client/_diagnostics.py 74.31% <0.00%> (-3.67%) ⬇️

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi dhalperi merged commit 06c4da5 into master Feb 22, 2023
@dhalperi dhalperi deleted the pr/dhalperi/master/dbbb939f branch February 22, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants