Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update values in Routing Policies notebook. #876

Merged
merged 2 commits into from
Feb 11, 2023
Merged

Conversation

nickgian
Copy link
Contributor

@nickgian nickgian commented Feb 3, 2023

This PR updates the values used in the "Analyzing Routing Policies" notebook to align them with the values produced by an updated version of SearchRoutePolicies from this PR.

Should be merged after batfish/batfish#8642.

@nickgian nickgian requested a review from ratulm February 3, 2023 21:58
@batfish-bot
Copy link

This change is Reviewable

@ratulm
Copy link
Member

ratulm commented Feb 8, 2023

@nickgian - ping me when upstream dependency is merged.

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ratulm)

@dhalperi dhalperi merged commit e4f7046 into batfish:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants