Add ignore_same_node option to assert_no_duplicate_router_ids #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arifogel
commented
Jan 22, 2023
- Fixes assert_no_duplicate_router_ids incorrectly flags reuse in multiple VRFs on same node #863
- Default to False
- When True, will not flag router-ids duplicated only on the same node
|
This change is |
arifogel
commented
Jan 23, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @arifogel, @dhalperi, and @sfraint)
a discussion (no related file):
Need to verify something prior to merge
- Fixes batfish#863 - Default to False - When True, will not flag router-ids duplicated only on the same node
ceac063 to
185b00d
Compare
dhalperi
reviewed
Jan 23, 2023
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @sfraint)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.