Skip to content

Commit

Permalink
Fix docker releases via GitHub actions
Browse files Browse the repository at this point in the history
tl;dr v1 is broken and poorly documented. We raised those concerns via
an issue. That should be fixed in v2: docker/build-push-action#88 (comment)
  • Loading branch information
bastelfreak committed Sep 27, 2020
1 parent e6c405b commit 552a9cd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Run tests
run: bundle exec rake rubocop
- name: Build and push Docker images
uses: docker/build-push-action@v1
uses: docker/build-push-action@v2
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
Expand All @@ -52,7 +52,7 @@ jobs:
tag_with_ref: true
tag_with_sha: true
- name: Build and push Docker images
uses: docker/build-push-action@v1
uses: docker/build-push-action@v2
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
Expand Down

0 comments on commit 552a9cd

Please sign in to comment.