Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax quoting reader var form (#') issue #889

Closed
ikappaki opened this issue Feb 26, 2024 · 0 comments · Fixed by #893
Closed

syntax quoting reader var form (#') issue #889

ikappaki opened this issue Feb 26, 2024 · 0 comments · Fixed by #893

Comments

@ikappaki
Copy link
Contributor

There appears to be an issue with syntax quoting a var reader form followed by unquoting.

To reproduce

  1. Open up the REPL, and use syntax quoting to get the var of a symbol using unquote notation. The result var form covers the empty local namespace.
basilisp.user=> (let [x 'inc] `(identity #'~x))
(basilisp.core/identity (var basilisp.user/) inc)

Contrast with Clojure

user> (let [x 'inc] `(identity #'~x))
(clojure.core/identity #'inc)
@ikappaki ikappaki mentioned this issue Mar 5, 2024
Merged
chrisrink10 pushed a commit that referenced this issue Mar 7, 2024
@ikappaki
Fix issue with syntax quoting reader var macro (#893)
3ab59a2 
Hi,

could you please consider fix for the issue with using the reader var
macro in syntax quotes. It fixes #889

I've also added a test.

Thanks

Co-authored-by: ikappaki <ikappaki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with syntax quoting reader var macro ikappaki/basilisp
1 participant
@ikappaki