Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

walk doesn't preserve metadata #1123

Closed
chrisrink10 opened this issue Nov 12, 2024 · 1 comment · Fixed by #1124
Closed

walk doesn't preserve metadata #1123

chrisrink10 opened this issue Nov 12, 2024 · 1 comment · Fixed by #1124
Labels
component:basilisp.walk Issue pertaining to basilisp.walk namespace issue-type:bug Something isn't working

Comments

@chrisrink10
Copy link
Member

basilisp.walk/walk (and anything based on it, such as postwalk and prewalk) doesn't preserve metadata.
@chrisrink10 chrisrink10 added issue-type:bug Something isn't working component:basilisp.walk Issue pertaining to basilisp.walk namespace labels Nov 12, 2024
@chrisrink10
Copy link
Member Author

basilisp.lang.reader._postwalk (a private and much more limited version of basilisp.walk/postwalk) also does not preserve metadata.

@chrisrink10 chrisrink10 mentioned this issue Nov 12, 2024
Merged
chrisrink10 added a commit that referenced this issue Nov 12, 2024
@chrisrink10
Preserve collection metadata in basilisp.walk/walk (#1124)
2fe510b 
Fixes #1123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:basilisp.walk Issue pertaining to basilisp.walk namespace issue-type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve collection metadata in basilisp.walk/walk basilisp-lang/basilisp
1 participant
@chrisrink10