You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
t appears that the CRLF newline sequence is being double counted when calculating the line number in the metadata.
To reproduce
Open up the basilisp REPL, evaluate a string that defines a variable after a single CRLF sequence, and then retrieve the metadata.a. The :line number in the meta is 3, instead of 2
…1064)
Hi,
can you please a fix for the line number in the metadata generated by
the reader. It fixes#1063.
We now check the char at -2 only if it’s:
- `\n` (for `\nC` or `\r\nC` case)
- `\r` (for the `\rC`, but not `\r\n`, case).
where `C` is any other char.
Added tests for the same.
Thanks
---------
Co-authored-by: ikappaki <ikappaki@users.noreply.github.com>
Hi,
t appears that the CRLF newline sequence is being double counted when calculating the line number in the metadata.
To reproduce
:line
number in the meta is 3, instead of 2For comparison, using a single newline character reports the correct line number:
PR to follow.
Thanks
The text was updated successfully, but these errors were encountered: