Improve Compiler Exception metadata handling (#846)

Fixes #844 Fixes #845
basilisp-lang · Jan 29, 2024 · b4d9c2d · b4d9c2d
1 parent e79a3c9
commit b4d9c2d
Show file tree

Hide file tree

Showing 6 changed files with 271 additions and 184 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Added
+ * Added filename metadata to compiler exceptions (#844)
+
+### Fixed
+ * Fix a bug where `basilisp.lang.compiler.exception.CompilerException` would nearly always suppress line information in it's `data` map (#845)
 
 ## [v0.1.0b1]
 ### Added

diff --git a/src/basilisp/contrib/nrepl_server.lpy b/src/basilisp/contrib/nrepl_server.lpy
@@ -122,7 +122,7 @@
   (let [{:keys [*1 *2 *3 *e eval-ns]} @client*
         out-stream                    (StreamOutFn #(send-fn request {"out" %}))
         reader                        (io/StringIO code)
-        ctx                           (basilisp.lang.compiler.CompilerContext. (or file "nREPL input"))
+        ctx                           (basilisp.lang.compiler.CompilerContext. (or file "<nREPL Input>"))
         eval-ns                       (if ns
                                         (create-ns (symbol ns))
                                         eval-ns)]