-
-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not attempt to resolve symbols in data reader tags (#1132)
Fixes #1129 For anyone who finds this PR (perhaps triaging a bug introduced by it in the future): I tried to ascertain exactly what Clojure JVM does in this situation and it is quite unclear in the reader code and not (at the time of writing) specified on any of the official documentation. Examples given there seem to indicate that fully qualified tags be given in `data_readers.cljc` and thus symbol resolution should not be performed on them, but they don't say explicitly. CLJS `#js []` literals work as they do now in this PR so I'm going to assume this is the intended behavior.
- Loading branch information
1 parent
7cdadd2
commit 60e9e09
Showing
3 changed files
with
258 additions
and
213 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.