fix: remove default item_width #5
Open
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit edits gum_chooser so that item_width is only passed when a value is provided. Removing default item_width seems to fix `[ ]` and the actual entry being in separate lines.
|
I might try fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if you'd be interested in this change.
I have noticed that non-selected items seem to be showing in a separate line from the prefix.
This only seems to be the case for unselected items.
At first, this sounded like a terminal specific problem. But i have tried a bunch of terminal emulators (mainly foot and xfce4-terminal) and the problem seems to persist.
Note that the problem does not seem to depend on the value of item_width (I have tried values as big as 5000 and the problem still persisted).
I believe making item_width an option that is only passed to gum when set is a good solution for this problem. I am not sure if the problem used to exist with gum or not, and I think sending them a PR is a better fix than making a PR here (since it'd fix the problem at it's root). But I figured (since I'm already using this) that you might be interested in merging this until gum is fixed.