-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Luke usage #433
Remove Luke usage #433
Conversation
riak_pipe powers MapReduce queries now
In reviewing other PRs, I was reminded that we can also remove the "mget" call from riak_kv_vnode. Luke-based MapReduce was the only thing that used it. |
Bryan, if you'd create a new issue to remove the No new failing EUnit failures, no significant changes to Dialyzer warnings. +1 to merge all 5 related PRs, many thanks! |
Can this be removed as part of this pr also? |
Nodes without Luke are unable to provide 'legacy' MapReduce. They can only provide 'pipe' MapReduce.
Good catch, @kellymclaughlin! Unfortunately, it can't be remove the However, new nodes also shouldn't lie about what they're capable of. I've just pushed a patch to remove |
Great point, I need to do that for my legacy keylisting pr as well. |
+1 to merge after last commit |
As of #433 (removal of luke), nothing uses this command.
It was removed when luke was removed in PR #433.
riak_pipe powers MapReduce queries now