Re-try temporary net errors, close connection if unsuccessful #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pguelpa - if it's convenient, could you try the fix on this branch in your environment? |
3505cf3 to
6fc3fbb
Compare
| logErr("[Node]", cmErr) | ||
| } | ||
| if !isTemporaryNetError(err) { | ||
| n.doHealthCheck() |
There was a problem hiding this comment.
Only health check when it's not a temporary network error.
6fc3fbb to
d4d856c
Compare
No need to sleep, just set the deadline itself Increase heisen-test timeout
d4d856c to
4473637
Compare
… msg code does happen when connections re-used with old code
|
Reminder: be sure to add an RPB test to |
|
👍 tests pass, code looks good. |
6d88633 to
f76d688
Compare
lukebakken
added a commit
that referenced
this pull request
Feb 19, 2016
…msg-code-error Re-try temporary net errors, close connection if unsuccessful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51 (CLIENTS-766)