Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean old templates, training code, deprecated serveres, and examples #834

Merged
merged 26 commits into from
Feb 26, 2024
Merged

Clean old templates, training code, deprecated serveres, and examples #834

merged 26 commits into from
Feb 26, 2024

Conversation

bolasim
Copy link
Collaborator

@bolasim bolasim commented Feb 24, 2024 •
edited
Loading

🚀 What

We added various things over the past to enable features that we no longer support. This PR is an effort course correct and move towards more modular packages in the repo that can be reused easily

💻 How

  • Drop training
  • Drop vllm, TGI, Triton custom dockers. We can do effectively the same by starting those server then using an async truss to proxy. All the vllm public examples do that and it's just as performant. We also added the OpenAI gateway/bridge, so we no longer need that from the vllm images.
  • Drop examples. We've settled on truss-examples

🔬 Testing

bolasim added 23 commits February 21, 2024 05:04
@bolasim
[RFC][POC] Run truss server as normal python process
1adaf1a
@bolasim
WIP: control server
c4b29eb
@bolasim
Working draft server
d7f8f2c
@bolasim
Fix tests
418b5af
@bolasim
WIP: continue fixing tests; issue with patch typing
1740eb2
@bolasim
Fix some mypy issues
5767e63
@bolasim
Clean up some more imports
940e201
@bolasim
Move test files
8eb962b
@bolasim
Move some things around for readabliity
039ec11
@bolasim
Cleanup everything except fs in tests
c218f1d
@bolasim
Only 4 tests left
9cf43dc
@bolasim
Revert changes to test data
86374ff
@bolasim
Fix all unit tests
6487959
@bolasim
Drop unnecessary config dump
50fdeee
@bolasim
Fix some integration tests; move packages dir
d69722d
@bolasim
Clean up logging and patches
8fe2155
@bolasim
Merge remote-tracking branch 'origin/main' into bola/split-out-server…
7562acf 
…-package
@bolasim
Fix packages path for TRT
dbd192e
@bolasim
Fix issue holding control server integration tests from passing
91b6d4a
@bolasim
Fix rest of integration tests
1818f25
@bolasim
Fix unit test and drop test_durations
51d9398
@bolasim
Fix last integration test by passing APP_HOME and adding to path
66bacb8
@bolasim
Clean old templates, training code, deprecated serveres, and examples
e4eef1f
@bolasim bolasim mentioned this pull request Feb 24, 2024
Closed
philipkiely-baseten
philipkiely-baseten reviewed Feb 24, 2024
View reviewed changes
Copy link
Member

@philipkiely-baseten philipkiely-baseten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a docs perspective, this looks good to me. Make sure to run mintlify broken-links before merging to ensure that there aren't any random references to deleted pages floating around.

Thank you for cleaning all of this stuff up!

squidarth
squidarth approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@squidarth squidarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this cleanup 👍

Base automatically changed from bola/split-out-server-package to main February 26, 2024 22:20
@bolasim bolasim merged commit daab03a into main Feb 26, 2024
10 checks passed
@bolasim bolasim deleted the bola/delete-unused-templates branch February 26, 2024 23:26
bolasim added a commit that referenced this pull request Mar 6, 2024
@basetenbot @philipkiely-baseten
@bolasim @helenlyang
Release 0.10.0-rc.0 (#851)
f5cab3c 
* minor copy update (#838)

* minor copy update

* correct TensorFlow capitalization

* Refactor `truss.server` out of templates to run as normal python program (#829)

* [RFC][POC] Run truss server as normal python process

* WIP: control server

* Working draft server

* Fix tests

* WIP: continue fixing tests; issue with patch typing

* Fix some mypy issues

* Clean up some more imports

* Move test files

* Move some things around for readabliity

* Cleanup everything except fs in tests

* Only 4 tests left

* Revert changes to test data

* Fix all unit tests

* Drop unnecessary config dump

* Fix some integration tests; move packages dir

* Clean up logging and patches

* Fix packages path for TRT

* Fix issue holding control server integration tests from passing

* Fix rest of integration tests

* Fix unit test and drop test_durations

* Fix last integration test by passing APP_HOME and adding to path

* Clean old templates, training code, deprecated serveres, and examples (#834)

* [RFC][POC] Run truss server as normal python process

* WIP: control server

* Working draft server

* Fix tests

* WIP: continue fixing tests; issue with patch typing

* Fix some mypy issues

* Clean up some more imports

* Move test files

* Move some things around for readabliity

* Cleanup everything except fs in tests

* Only 4 tests left

* Revert changes to test data

* Fix all unit tests

* Drop unnecessary config dump

* Fix some integration tests; move packages dir

* Clean up logging and patches

* Fix packages path for TRT

* Fix issue holding control server integration tests from passing

* Fix rest of integration tests

* Fix unit test and drop test_durations

* Fix last integration test by passing APP_HOME and adding to path

* Clean old templates, training code, deprecated serveres, and examples

* reset vscode settings

* Fix integration test using example

* Improve `truss watch`: respect `.truss_ignore` when calculating patches (#812)

Although we currently account for truss ignore patterns when detecting file changes with watchfiles.watch, we do not 
account for the ignore patterns when calculating patches or the truss hash and signature. This means that changes in 
ignored files will still be patched. This PR fixes that, along with some refactoring and bug fixes.

* Fix integration tests (#843)

* add pathspec to pyproject

* poetry lock --no-update

* fix calc_patch call

* Fix os.PathLike type annotation

This changes the `os.PathLike[Any]` annotation to `os.PathLike`. `os.PathLike` isn't subscriptable in Python 3.8, so 
`os.PathLike[Any]` results in `TypeError: 'ABCMeta' object is not subscriptable`.

* Fall back to default .truss_ignore in truss upload

If a user doesn't provide a .truss_ignore in their truss directory, fall back to the default .truss_ignore file specified in the 
truss package.

* Move build configuration script to truss (#847)

* Move build configuration script to truss

* Update pyproject.toml

* Move build configuration script to truss

* Update pyproject.toml

* Fix unintentially ignore build directory

* Bump version to 0.10.0-rc.0

---------

Co-authored-by: Philip Kiely - Baseten <98474633+philipkiely-baseten@users.noreply.github.com>
Co-authored-by: Bola Malek <bola@baseten.co>
Co-authored-by: helenlyang <helen.yang@baseten.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipkiely-baseten philipkiely-baseten philipkiely-baseten left review comments

@squidarth squidarth squidarth approved these changes

@marius-baseten marius-baseten marius-baseten approved these changes

@pankajroark pankajroark Awaiting requested review from pankajroark

@aspctu aspctu Awaiting requested review from aspctu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bolasim @squidarth @philipkiely-baseten @marius-baseten