Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env vars to vite config #2094

Merged
merged 1 commit into from
Mar 27, 2025
Merged

add env vars to vite config #2094

merged 1 commit into from
Mar 27, 2025

Conversation

brendan-defi
Copy link
Collaborator

@brendan-defi brendan-defi commented Mar 27, 2025

What changed? Why?

  • Added env vars to vite config
  • This enables OnchainKit components that require apiKey and/or projectId

Notes to reviewers

How has it been tested?

Have you tested the following pages?

BaseWeb

  • base.org
  • base.org/names
  • base.org/builders
  • base.org/ecosystem
  • base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

BaseDocs

  • docs.base.org
  • docs sub-pages

before:
image

after:
image

Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 6:34pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 6:34pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 27, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for dgca @ 2025-03-27 20:05:16 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@brendan-defi brendan-defi merged commit 32d7e21 into master Mar 27, 2025
9 checks passed
@brendan-defi brendan-defi deleted the feat/docs-env-vars branch March 27, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants