Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding to workspace dictionary doesn't seem to do anything #99

Closed
tasgon opened this issue Dec 5, 2017 · 7 comments
Closed

Adding to workspace dictionary doesn't seem to do anything #99

tasgon opened this issue Dec 5, 2017 · 7 comments

Comments

@tasgon
Copy link

tasgon commented Dec 5, 2017

Whenever I add click on 'Add "<word>" to workspace dictionary', the word still gets marked as incorrect. However, adding to the user dictionary has the correct effect.

Am I missing something here?

@bartosz-antosik
Copy link
Owner

Hi! I am tempted to say: Strange, it works for me! ;-)

But of course there may be something I am missing (see questions below).

image

image

Could you please check:

  1. Is spellright.dict present in your workspace's .vscode folcer?
  2. Has the word been added there?

@el2iot2
Copy link

el2iot2 commented Dec 9, 2017

I hit this as well, but figured it out. The problem was that, while i had saved a myproject.code-workspace for my project, i hadn't yet caused a .vscode folder to be created. When I customized the "workspace settings" (ctrl+p,>,open workspace settings), suddenly i had a .vscode folder and the "add to workspace dictionary" command worked as advertised. I would assume that if you manually added an appropriate .vscode folder, you could get this working as well.

There are probably other, better/quicker ways to create the .vscode folder for a new project, but
ctrl+p,>,open workspace settings worked for me. I also had to pull down "Workspace Settings" from the settings combo before the .vscode folder (and internal settings file) were created:
image

@bartosz-antosik
Copy link
Owner

@el2iot2 Thanks for the input! I will have to think on this - maybe I should 1) disable this option 2) create .vscode folder on my own?

@el2iot2
Copy link

el2iot2 commented Dec 9, 2017

2 seems reasonable to me if you ask permission to add the .vscode folder in a modal?

Could also toast a message: "cannot add word to workspace dictionary because there is not yet a .vscode folder for this project"?

@el2iot2
Copy link

el2iot2 commented Dec 9, 2017

As a side note, I have tried a bunch of spell checker plugins, and this is the first that has been reliable and perfomant (and offline) for long markdown files. It works intuitively and well. Thank you for all the effort and work in this space.

@bartosz-antosik
Copy link
Owner

Just published version 2.0.15 should fix this. Bu creating the .vscode folder if necessary. I have made a look around and I reckon some extensions create the folder if it does not exist. So it seems legit!

Thanks for kind words in the post above! Maybe you would like to create a review in the market? ;-)

@tasgon
Copy link
Author

tasgon commented Dec 17, 2017

Thanks a bunch for all the hard work you've put into this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants