Persistent settings are problematic

[borekb]

2.0 introduced settings persistence which is problematic for us: we normally don't check certain document types but locally, sometimes I want to turn it on. Before 2.0, I could just click the "eye" icon in the status bar and change it to whatever I found convenient locally. With 2.0, this immediately writes to .vscode/settings.json which is a Git-versioned file so I get changed Git state. Even if there was no workspace settings and SpellRight would write to my user settings, that would also be problematic because I synchronize my settings between computers and this would create a lot of noise.

The previous approach was better, IMO. I could experiment with various levels of spell checking and only when I'm happy with them, manually write those to either user or workspace settings.

[bartosz-antosik]

I must say, that I partially agree with you. I love the change to workspace settings, it is much more clearer now. So I will definitely not go back to spellright.json settings which was closely related to the Update settings command. I think for many casual users what is now may be far more acceptable as it does not require getting any knowledge about the extension's internals, they just want to spell something and have it spelled whenever the editor opens...

As usually - I will think of something.

[borekb]

The move to standard settings is certainly a good one, the problematic part for me is the automatic persistence. This is always tricky, for example, VSCode itself writes the zoom level to settings.json which I don't agree with: I have several computers and each one needs a different value there. Of course there are many other things that are not persisted, like whether my left sidebar is open or not. It's a question whether SpellRight should persist or not but I had no problem with the approach so far: it allowed for easy experimenting and I only updated my settings.json where I found it appropriate.

[bartosz-antosik]

I had same problem with font size between lo/high DPI monitors. Luckily Settings Sync has the ability to exclude certain settings from synchronization.

[bartosz-antosik]

I did the changes, but with the multi root workspaces thing like this (changing settings independently of what is in the configuration files) is very complicated & possibly faulty. Please, test whether it works for you and whether there any issues related to this. All is contained under spellright.updateConfiguration setting.

It will be present in just released version 2.0.2.

[borekb]

Works great! Thank you.