Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings names should be wrapped in quotes #185

Closed
fontaines opened this issue Jul 26, 2018 · 3 comments
Closed

Settings names should be wrapped in quotes #185

fontaines opened this issue Jul 26, 2018 · 3 comments

Comments

@fontaines
Copy link

fontaines commented Jul 26, 2018

Hello,

In your README, you explain settings exposed by your extension. (Your documentation was a pleasure to read, by the way. I wish all documentations were like yours!) However, I couldn't get any of your settings snippets to work. For example, this one:

spellright.statusBarIndicator: false

It turns out that (on my Mac computer, at least) settings names must imperatively be surrounded by double quotes:

"spellright.statusBarIndicator": false

@bartosz-antosik
Copy link
Owner

Great idea! I think will do this on next release.

Thank you for kind words about documentation and I am very happy someone actually read it! ;-)

@bartosz-antosik
Copy link
Owner

Should be done in version 2.5.24. Please let me know if I have missed something.

@fontaines
Copy link
Author

Fantastic! Thank you for your responsiveness and thank you for the hours you spend maintaining and supporting this extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants