-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not catching misspellings in some Markdown areas #105
Comments
Hi! No, it probably does not affect other places. It was caused consciously by #100 and I have no idea at the moment how to reasonably judge whether something that is indented by 4 spaces is code block or bullet. Now I even have doubts whether indent of four spaces really does introduce code block... |
Four space indent does introduce a code block (commonmark should provide some spec details here). Based on some tests you may not be able to get by with stateless, logic-less regex alone to determine what is and isn't a codeblock (you might have to count what level you are at, at which point if you really want to do it right, you grab an actual markdown parser or you leverage vscode's built in one somehow to access the AST). |
Thanks for the input. I will have to deliberate on this a while. |
In version 2.1.0 the regular expression is refined to resolve the case reported. It does not resolve the problem generally and there may be some cases (e.g. far level bullet - code - bullet paragraph continuation) which will generate a false positive but it should help. I will close the thread but l leave a note in my TODO file to maybe investigate it deeper. Would love someone to help refine the internal parser because as far as I can tell there is no way to use VSCodes internal parser! |
Some nested bullets don't get checked, e.g.
Notice how the third and fourth there aren't checked. There are probably other places in the markdown file that don't get checked either.
The text was updated successfully, but these errors were encountered: