Skip to content

Commit

Permalink
Improve release note for using GNUInstallDirs by default (trilinos#12104
Browse files Browse the repository at this point in the history
)

Hopefully this improved release note will help customers transition to
Trilinos using the standard GNUInstallDirs module.  I also added a mention
that Trilinos may only support GNUIntallDirs in the future so customers should
get usesd to working with it.
  • Loading branch information
bartlettroscoe committed Sep 23, 2023
1 parent 5e9ec8f commit a6a34b5
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions RELEASE_NOTES
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,30 @@
CMake

- Change the default for `Trilinos_MUST_FIND_ALL_TPL_LIBS` from `OFF` to
`ON`. It was
turned off by default because it breaks backward compatibility but it also
causes problems for new users and new configurations.
`ON`. It was turned off by default because it breaks backward
compatibility but it also causes problems for new users and new
configurations.

Users that do not want this new behavior can set
`-D Trilinos_MUST_FIND_ALL_TPL_LIBS=OFF`, which is backward compatible.

- Change the default for `Trilinos_USE_GNUINSTALLDIRS` from `OFF` to `ON`,
in the goal to
move Trilinos and TriBITS to modern CMake.
in the goal to move Trilinos and TriBITS to modern CMake.

TriBITS has had the ability to use that paths selected by the standard
CMake module `GNUInstallDirs.cmake` for a long time. But it is turned off
in TriBITS by default and was never turned on in Trilinos, both for the
sake of backward compatibility.

This may break people's existing configurations because it will install
libs in `<prefix>/libs64/` instead of in `<instead>/libs/`. See
libs in `<prefix>/libs64/` instead of in `<prefix>/libs/` on many systems
(e.g. Linux systems). To revert back to using `<prefix>/lib` but still
use `GNUInstallDirs.cmake` for Trilinos, set `-D
CMAKE_INSTALL_LIBDIR:STRING=lib`. NOTE: The setting `-D
Trilinos_USE_GNUINSTALLDIRS=OFF` is deprecated and may be removed in the
future. (I.e. the usage of `GNUInstallDirs.cmake` may be hard-coded in the
future so please try adjusting to the usage of `GNUInstallDirs.cmake` by
Trilinos.) See
https://github.com/trilinos/Trilinos/issues/12104#issuecomment-1691945033
for additional details and instructions.

Expand Down

0 comments on commit a6a34b5

Please sign in to comment.