Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #892 #894

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Fixed #892 #894

merged 2 commits into from
Mar 3, 2020

Conversation

UksusoFF
Copy link
Contributor

@UksusoFF UksusoFF commented Feb 28, 2020 •
edited
Loading

Fixed #892

@mfn
Copy link
Collaborator

mfn commented Feb 29, 2020

@UksusoFF one feedback tough: the reason I broke it I think is easy: there was no test for it.

Now you changed it and no test needed adaption => I can already foresee in the future someone will break it again etc.

Suggestion: can you please add a test which, in case this would be changed (like without this PR) it would show it breaks?

thanks!

mfn
mfn approved these changes Mar 2, 2020
View reviewed changes
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, it's a 👍 from my side!

ping @barryvdh

@mfn
Copy link
Collaborator

mfn commented Mar 2, 2020

(I doubled checked by reverting the code change and checking the failed tests)

@barryvdh barryvdh merged commit e743f44 into barryvdh:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfn mfn mfn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relations with query not work again
3 participants
@UksusoFF @mfn @barryvdh