Add default values to array_merge #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
approved these changes
Mar 17, 2021
|
For future reference it is reproducable:
That said the config should not be cached in dev mode. |
|
@netpok can you add a changelog entry? I missed this in the review 😢 |
|
Should I just commit it to this branch? |
|
Ah, no, I fear it needs a separate PR 😬 |
mfn
added a commit
that referenced
this pull request
Mar 22, 2021
Add missing changelog entry for #1184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds default values so array_merge does not break when config values are missing. This should not happen unless the package is freshly installed and config is cached.
Fixes #1180
Type of change
Checklist
composer fix-style