Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove format and broken generateJsonHelper #1053

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Remove format and broken generateJsonHelper #1053

merged 1 commit into from
Dec 4, 2020

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Sep 10, 2020 •
edited
Loading

Summary

The JSON generate doesn't work, always generates an empty list.

I looked a bit around and seems changes around 3 years ago broke it.

Since there was no bug report ever about this, I conclude this feature
isn't used and suggest to remove it.

This also changes the config filename as there's no need for the
extension-less version and the format is gone too. This change is
backwards compatible as we just add back the .php in case it's missing
though users are encouraged to update it.

Links

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn mfn self-assigned this Sep 10, 2020
@mfn mfn force-pushed the mfn-rm-json-helper branch 2 times, most recently from 849f169 to 0597458 Compare September 10, 2020 23:31
@mfn mfn changed the title Remove generateJsonHelper Remove format and generateJsonHelper Sep 10, 2020
@mfn mfn changed the title Remove format and generateJsonHelper Remove format and broken generateJsonHelper Sep 10, 2020
@mfn mfn force-pushed the mfn-rm-json-helper branch from 0597458 to 4558245 Compare September 10, 2020 23:32
@mfn mfn requested a review from barryvdh September 10, 2020 23:32
@mfn mfn mentioned this pull request Sep 28, 2020
Closed
@mfn
Remove format and broken generateJsonHelper
900bfb2 
The JSON generate doesn't work, always generates an empty list.

I looked a bit around and seems changes around 3 years ago broke it.

Since there was no bug report ever about this, I conclude this feature
isn't used and suggest to remove it.

This also changes the config `filename` as there's no need for the
extension-less version and the format is gone too. This change is
backwards compatible as we just add back the `.php` in case it's missing
though users are encouraged to update it.
@mfn mfn force-pushed the mfn-rm-json-helper branch from 4558245 to 900bfb2 Compare September 28, 2020 03:54
@mfn
Copy link
Collaborator Author

mfn commented Dec 4, 2020

@barryvdh friendly ping, I believe this is all dead code

@barryvdh barryvdh merged commit ae5d770 into barryvdh:master Dec 4, 2020
@mfn mfn deleted the mfn-rm-json-helper branch December 4, 2020 11:35
@mfn
Copy link
Collaborator Author

mfn commented Dec 4, 2020

thank you @barryvdh !

@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barryvdh barryvdh barryvdh approved these changes

Assignees

@mfn mfn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

json format for ide-helper:generate not working
2 participants
@mfn @barryvdh