Add (initial) support for PHP 8.4 (#1631)

* Run tests on PHP 8.4 * Update integration test to actually test clear command functionality
barryvdh · Oct 30, 2024 · 3ad206c · 3ad206c
1 parent 423ee47
commit 3ad206c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.github/workflows/run-integration-tests.yml b/.github/workflows/run-integration-tests.yml
@@ -18,7 +18,7 @@ jobs:
             COMPOSER_NO_INTERACTION: 1
         strategy:
             matrix:
-                php: [8.3, 8.2, 8.1, 8.0]
+                php: [8.4, 8.3, 8.2, 8.1, 8.0]
                 lumen: [10.*, 9.*]
                 exclude:
                   - lumen: 10.*
@@ -54,10 +54,11 @@ jobs:
             - name: Execute clear run
               run: |
                   cd sample
+                  mkdir -p "storage/debugbar/" && touch "storage/debugbar/foo.json"
                   php artisan debugbar:clear
             - name: Check file count in logs
               run: |
-                if [ `ls -1q "sample/storage/logs/" | wc -l` -gt 0 ];then exit 1;fi
+                if [ `ls -1q "sample/storage/debugbar/" | wc -l` -gt 0 ];then exit 1;fi
     php-laravel-integration-tests:
         runs-on: ubuntu-latest
         timeout-minutes: 15
@@ -66,7 +67,7 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                php: [8.3, 8.2, 8.1, 8.0]
+                php: [8.4, 8.3, 8.2, 8.1, 8.0]
                 laravel: [11.*, 10.*, 9.*]
                 exclude:
                   - laravel: 10.*
@@ -103,7 +104,8 @@ jobs:
             - name: Execute generate run
               run: |
                   cd sample
+                  mkdir -p "storage/debugbar/" && touch "storage/debugbar/foo.json"
                   php artisan debugbar:clear
             - name: Check file count in logs
               run: |
-                if [ `ls -1q "sample/storage/logs/" | wc -l` -gt 0 ];then exit 1;fi
+                if [ `ls -1q "sample/storage/debugbar/" | wc -l` -gt 0 ];then exit 1;fi
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -20,7 +20,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php: [8.3, 8.2, 8.1, 8.0]
+        php: [8.4, 8.3, 8.2, 8.1, 8.0]
         laravel: [^11, ^10, ^9]
         dependency-version: [prefer-stable]
         exclude: