fix(#23): remove user from your last review list

barbosamaatheus · May 26, 2020 · 92bb18a · 92bb18a
1 parent a9a1719
commit 92bb18a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/services/ApprovalDialogService.js b/src/services/ApprovalDialogService.js
@@ -20,8 +20,8 @@ module.exports = async (req, res) => {
         .send();
 
     const index = dialogue.disapprovals.indexOf(userId);
-    if (index > -1)
-      dialogue.disapprovals = dialogue.disapprovals.splice(index, 1);
+
+    if (index > -1) dialogue.disapprovals.splice(index, 1);
 
     if (dialogue.approvals.includes(userId))
       return response

diff --git a/src/services/RejectDialogService.js b/src/services/RejectDialogService.js
@@ -20,8 +20,8 @@ module.exports = async (req, res) => {
         .send();
 
     const index = dialogue.approvals.indexOf(userId);
-    
-    if (index > -1) dialogue.approvals = dialogue.approvals.splice(index, 1);   
+
+    if (index > -1) dialogue.approvals.splice(index, 1);
 
     if (dialogue.disapprovals.includes(userId))
       return response