Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Probes] attributes "count" is written to duplicated path #157

Closed
piyueh opened this issue Jul 13, 2020 · 1 comment
Closed

[Probes] attributes "count" is written to duplicated path #157

piyueh opened this issue Jul 13, 2020 · 1 comment

Comments

@piyueh
Copy link
Member

piyueh commented Jul 13, 2020

At line 565 in probes.cpp, an attribute, count, is written to root/field/field/time.

@mesnardo Is this intentional? Or is it supposed to be written to root/field/time? (The viewer object at this line is already under root/field when calling this function.)

For example, if the field is p, and if the HDF5 file is read into data, then the count attribute of time 10.0 will be at:
data["p"]["p"]["10.000000"].attrs["count"]
according to our current implementation at line 565 in probes.cpp.
@piyueh piyueh mentioned this issue Jul 13, 2020
Merged
@mesnardo
Copy link
Member

Good catch! No need to have this extra field (i.e., can be moved to one node up). count represents the number of time-steps over which the data were accumulated.

@piyueh piyueh closed this as completed in 711d8e8 Jul 13, 2020
piyueh added a commit that referenced this issue Jul 13, 2020
@piyueh
Merge pull request #159 from piyueh/fix-probe-count-attrs
a657821 
fix #157 -- Move attribute `count` to the corresponding dataset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mesnardo @piyueh