🐛 (editor) Fix outside click not working in some cases

baptisteArno · Jan 26, 2023 · 0fc82cf · 0fc82cf
1 parent 01c9691
commit 0fc82cf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/apps/builder/src/components/VariableSearchInput.tsx b/apps/builder/src/components/VariableSearchInput.tsx
@@ -58,7 +58,7 @@ export const VariableSearchInput = ({
 
   useOutsideClick({
     ref: dropdownRef,
-    handler: () => onClose,
+    handler: onClose,
   })
 
   useEffect(() => {
@@ -189,6 +189,7 @@ export const VariableSearchInput = ({
             w="inherit"
             shadow="lg"
             onMouseDown={(e) => e.stopPropagation()}
+            onPointerDown={(e) => e.stopPropagation()}
           >
             {isCreateVariableButtonDisplayed && (
               <Button

diff --git a/...r/src/features/blocks/bubbles/textBubble/components/TextBubbleEditor/TextBubbleEditor.tsx b/...r/src/features/blocks/bubbles/textBubble/components/TextBubbleEditor/TextBubbleEditor.tsx
@@ -148,6 +148,9 @@ const TextBubbleEditorContent = ({
             rememberedSelection.current = editor.selection
           },
           onKeyDown: handleKeyDown,
+          onClick: () => {
+            setIsVariableDropdownOpen(false)
+          },
         }}
       />
       {isVariableDropdownOpen && (

diff --git a/apps/builder/src/hooks/useOutsideClick.ts b/apps/builder/src/hooks/useOutsideClick.ts
@@ -6,13 +6,11 @@ type Handler = (event: MouseEvent) => void
 type Props<T> = {
   ref: RefObject<T>
   handler: Handler
-  mouseEvent?: 'mousedown' | 'mouseup'
 }
 
 export const useOutsideClick = <T extends HTMLElement = HTMLElement>({
   ref,
   handler,
-  mouseEvent = 'mousedown',
 }: Props<T>): void => {
   const triggerHandlerIfOutside = (event: MouseEvent) => {
     const el = ref?.current
@@ -22,5 +20,5 @@ export const useOutsideClick = <T extends HTMLElement = HTMLElement>({
     handler(event)
   }
 
-  useEventListener(mouseEvent, triggerHandlerIfOutside)
+  useEventListener('pointerdown', triggerHandlerIfOutside)
 }