Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade] Go-Ethereum release v1.10.4 #72

Draft
wants to merge 558 commits into
base: master
Choose a base branch
from

Conversation

baptiste-b-pegasys
Copy link
Owner

TODO

Plan & Analyse

  • Review the Release Notes
  • Review PRs in the section below

As you review, list extra changes and/or tests to be implemented to ensure compatibility with GoQuorum specific features.

Build & Test

  • Pull and checkout PR branch locally, then merge GoQuorum master into this branch
  • Resolve conflicts, taking into account the prior analysis
  • Implement required changes until lint passes
  • Implement required changes until all unit tests pass
  • Implement required changes until acceptance tests pass
  • Implement extra changes and/or tests
  • Verify any left TODOs in the code

Add any extra changes/tests as comments on this PR.

Go-Ethereum Release: Voyager Cluster (v1.10.4)

  • Version: v1.10.4
  • Published: 2021-06-17T10:37:35Z

Release notes

Codebase changes assessment

Legend

File Stats: (A) Added, (M) Modified and (R) Removed

Line Stats: (A) Added and (R) Removed

Assessment:

  • ✅ No conflict expected
  • ⚠ Review required to assess changes
  • ‼️ Conflicts expected and review required

85 Pull Requests

🔍 Link Title File Stats
M/A/R
Packages changed
(files changed)
Line Stats
A/R
Top 5 Changed Files
(lines changed)
‼️ # 22825 core: single end logging in json logger 1/0/0
core/vm (1)
3/2
core/vm/logger_json.go (10)
‼️ # 22822 all: define London+baikal, undefine yolov3, add london override flag 21/0/0
cmd/geth (6)
core (4)
params (2)
les (1)
core/types (1)
core/vm/runtime (1)
eth (1)
eth/ethconfig (1)
tests (1)
cmd/puppeth (1)
cmd/utils (1)
core/state (1)
100/82
cmd/utils/flags.go (72)
params/config.go (68)
tests/init.go (44)
core/genesis.go (40)
cmd/geth/dbcmd.go (32)
‼️ # 22809 core: implement EIP-3541 2/0/0
core/vm (2)
6/0
core/vm/evm.go (10)
core/vm/errors.go (2)
‼️ # 22733 core, params: implement EIP-3529 7/0/0
core/vm (4)
core (2)
params (1)
166/114
core/vm/operations_acl.go (420)
core/vm/eips.go (52)
core/state_transition.go (30)
params/protocol_params.go (30)
core/vm/jump_table.go (18)
⚠️ # 22836 consensus/clique: add some missing checks 1/0/0
consensus/clique (1)
19/0
consensus/clique/clique.go (38)
# 22832 rlp: add support for optional struct fields 6/0/0
rlp (6)
330/45
rlp/decode_test.go (362)
rlp/doc.go (122)
rlp/typecache.go (108)
rlp/encode.go (78)
rlp/encode_test.go (44)
‼️ # 22848 build: upgrade -dlgo version to Go 1.16.4 2/0/0
build (2)
14/14
build/checksums.txt (52)
build/ci.go (4)
‼️ # 22844 cmd/geth: remove reference to monitor command 1/0/0
cmd/geth (1)
1/1
cmd/geth/consolecmd.go (4)
‼️ # 22745 deps: update uint256 to 1.2.0 5/0/0
core/vm (2)
consensus/ethash (1)
go.mod (1)
go.sum (1)
9/9
consensus/ethash/difficulty.go (12)
core/vm/instructions_test.go (8)
core/vm/logger_test.go (8)
go.mod (4)
go.sum (4)
# 22841 eth/protocols/eth, les: avoid Raw() when decoding HashOrNumber 2/0/0
eth/protocols/eth (1)
les (1)
24/24
eth/protocols/eth/protocol.go (48)
les/protocol.go (48)
⚠️ # 22851 eth/protocols/snap: adapt to uint256 API changes 1/0/0
eth/protocols/snap (1)
9/8
eth/protocols/snap/range.go (34)
‼️ # 22852 core/types: remove support for legacy receipt/log storage encoding 3/0/0
core/types (3)
7/244
core/types/receipt_test.go (246)
core/types/receipt.go (178)
core/types/log.go (78)
‼️ # 22752 Add a --gpo.ignoreprice option to ignore MEV-priced txs 5/0/0
cmd/geth (2)
eth/ethconfig (1)
eth/gasprice (1)
cmd/utils (1)
43/20
eth/gasprice/gasprice.go (78)
eth/ethconfig/config.go (28)
cmd/utils/flags.go (16)
cmd/geth/main.go (2)
cmd/geth/usage.go (2)
‼️ # 22857 eth/tracers: do the JSON serialization via .js to capture C faults 2/0/0
eth/tracers (2)
28/10
eth/tracers/tracer.go (48)
eth/tracers/tracer_test.go (28)
‼️ # 22780 core: ensure state could be created in ToBlock 1/0/0
core (1)
4/1
core/genesis.go (10)
‼️ # 22840 consensus/ethash: implement EIP-3554 (bomb delay) 1/0/0
consensus/ethash (1)
7/0
consensus/ethash/consensus.go (14)
# 22795 cmd/geth, eth, core: snapshot dump + unify with trie dump 10/0/0
cmd/evm (2)
cmd/geth (2)
core/state (2)
eth (2)
cmd/utils (1)
cmd/evm/internal/t8ntool (1)
293/88
cmd/geth/chaincmd.go (224)
cmd/geth/snapshot.go (194)
core/state/dump.go (160)
eth/api_test.go (46)
core/state/state_test.go (38)
‼️ # 22871 cmd/evm: return json error if unmarshalling from stdin fails 1/0/0
cmd/evm/internal/t8ntool (1)
9/7
cmd/evm/internal/t8ntool/transition.go (32)
‼️ # 22870 consensus/ethash: change eip3554 from 9.5M to 9.7M 1/0/0
consensus/ethash (1)
2/2
consensus/ethash/consensus.go (8)
‼️ # 22837 all: implement eip-1559 14/15/1
core (7)
cmd/evm/testdata/10 (4)
cmd/evm/testdata/11 (4)
cmd/evm/testdata/9 (4)
cmd/evm/internal/t8ntool (3)
consensus/misc (3)
accounts/abi/bind/backends (1)
accounts/external (1)
consensus/clique (1)
consensus/ethash (1)
cmd/evm (1)
905/73
core/blockchain_test.go (314)
consensus/misc/eip1559_test.go (266)
consensus/misc/eip1559.go (186)
cmd/evm/testdata/10/readme.md (158)
cmd/evm/testdata/9/readme.md (150)
‼️ # 22888 core: fix failing tests 2/0/0
core (2)
19/4
core/state_processor_test.go (38)
core/blockchain_test.go (8)
‼️ # 22878 core/rawdb: wait for background freezing to exit when closing freezer 2/0/0
core/rawdb (2)
8/1
core/rawdb/database.go (12)
core/rawdb/freezer.go (6)
# 22883 core/asm: fix the bug of "00" prefix number 2/0/0
core/asm (2)
5/1
core/asm/lex_test.go (8)
core/asm/lexer.go (4)
‼️ # 22879 core/forkid: fix off-by-one bug 2/0/0
core/forkid (2)
5/1
core/forkid/forkid_test.go (8)
core/forkid/forkid.go (4)
# 22842 p2p/discover/v4wire: use optional RLP field for EIP-868 seq 4/0/0
p2p/discover (2)
p2p/discover/v4wire (2)
17/47
p2p/discover/v4wire/v4wire_test.go (48)
p2p/discover/v4wire/v4wire.go (46)
p2p/discover/v4_udp.go (18)
p2p/discover/v4_udp_test.go (16)
# 22858 rlp: improve decoder stream implementation 1/0/0
rlp (1)
86/89
rlp/decode.go (350)
‼️ # 22900 cmd/utils: expand tilde in --jspath 1/0/0
cmd/utils (1)
2/2
cmd/utils/flags.go (8)
# 22876 eth, p2p/msgrate: move peer QoS tracking to its own package and use it for snap 5/1/1
eth/downloader (4)
eth/protocols/snap (2)
p2p/msgrate (1)
745/409
p2p/msgrate/msgrate.go (916)
eth/protocols/snap/sync.go (662)
eth/downloader/peer.go (342)
eth/downloader/downloader.go (238)
eth/downloader/peer_test.go (106)
# 22906 p2p/dnsdisc: fix crash when iterator closed before first call to Next 2/0/0
p2p/dnsdisc (2)
21/0
p2p/dnsdisc/client_test.go (30)
p2p/dnsdisc/client.go (12)
‼️ # 22896 EIP-1559: miner changes 10/0/0
core (5)
miner (2)
core/types (2)
eth/catalyst (1)
206/48
core/types/transaction.go (160)
core/types/transaction_test.go (126)
core/block_validator.go (72)
core/block_validator_test.go (66)
miner/worker.go (56)
# 22911 core/rawdb: table compaction doesn't handle the prefix 1/0/0
core/rawdb (1)
4/0
core/rawdb/table.go (8)
# 22921 les: generate random nums directly, not via strange conversions 5/0/0
les (5)
10/16
les/retrieve.go (18)
les/client_handler.go (14)
les/odr.go (10)
les/txrelay.go (6)
les/fetcher.go (4)
# 22919 miner/stress: update stress tests 0/0/2
miner/stress/clique (1)
miner/stress/ethash (1)
5/7
miner/stress/ethash/main.go (14)
miner/stress/clique/clique.go (10)
# 22902 rlp: use atomic.Value for type cache 4/0/0
rlp (4)
94/29
rlp/typecache.go (164)
rlp/encode_test.go (66)
rlp/decode.go (8)
rlp/encode.go (8)
‼️ # 22924 rlp: optimize byte array handling 4/2/0
rlp (6)
146/50
rlp/encode.go (112)
rlp/decode_test.go (88)
rlp/unsafe.go (70)
rlp/safe.go (52)
rlp/encode_test.go (38)
‼️ # 22933 core: make txpool free space calculation more accurate 1/0/0
core (1)
1/1
core/tx_pool.go (4)
⚠️ # 22937 rlp, tests/fuzzers/bls12381: gofmt 2/0/0
rlp (1)
tests/fuzzers/bls12381 (1)
2/2
rlp/safe.go (4)
tests/fuzzers/bls12381/bls12381_fuzz.go (4)
# 22927 rlp: optimize big.Int decoding for size <= 32 bytes 3/0/0
rlp (3)
74/16
rlp/decode.go (120)
rlp/decode_test.go (44)
rlp/encode_test.go (16)
‼️ # 22908 eth: unregister peer only when handler exits 3/0/0
eth (2)
p2p (1)
60/30
eth/handler_eth_test.go (118)
p2p/peer.go (32)
eth/handler.go (30)
# 22718 internal/ethapi: merge CallArgs and SendTxArgs 4/1/0
eth/tracers (2)
internal/ethapi (2)
graphql (1)
236/223
internal/ethapi/api.go (488)
internal/ethapi/transaction_args.go (370)
eth/tracers/api_test.go (40)
graphql/graphql.go (16)
eth/tracers/api.go (4)
⚠️ # 22877 p2p/nat: skip TestUPNP in non-CI envs if discover fails 1/0/0
p2p/nat (1)
6/1
p2p/nat/natupnp_test.go (14)
# 22941 tests: get test name from testing.T 7/0/0
tests (7)
16/19
tests/init_test.go (20)
tests/state_test.go (18)
tests/block_test.go (8)
tests/difficulty_test.go (8)
tests/vm_test.go (8)
‼️ # 22843 cmd/devp2p: refactor eth test suite 4/1/2
cmd/devp2p/internal/ethtest (7)
1467/1422
cmd/devp2p/internal/ethtest/suite.go (1688)
cmd/devp2p/internal/ethtest/helpers.go (1270)
cmd/devp2p/internal/ethtest/eth66_suite.go (1042)
cmd/devp2p/internal/ethtest/eth66_suiteHelpers.go (666)
cmd/devp2p/internal/ethtest/transaction.go (596)
# 21640 ethstats: fix URL parser for '@' or ':' in nodename 1/1/0
ethstats (2)
97/9
ethstats/ethstats_test.go (134)
ethstats/ethstats.go (78)
‼️ # 22942 internal/ethapi: remove unused vm.Config parameter of DoCall 2/0/0
graphql (1)
internal/ethapi (1)
5/6
internal/ethapi/api.go (12)
graphql/graphql.go (10)
‼️ # 22944 core/state/snapshot: fix flaky tests 1/0/0
core/state/snapshot (1)
13/13
core/state/snapshot/generate_test.go (52)
‼️ # 22952 ethstats: fix typo in comment 1/0/0
ethstats (1)
1/1
ethstats/ethstats.go (4)
‼️ # 22949 cmd/utils: avoid 1Gb alloc in --dev mode 2/0/0
cmd/geth (1)
cmd/utils (1)
5/1
cmd/utils/flags.go (8)
cmd/geth/genesis_test.go (4)
# 22899 p2p/rlpx: reduce allocation and syscalls 5/2/0
p2p/rlpx (4)
rlp (2)
p2p (1)
478/227
p2p/rlpx/rlpx.go (770)
p2p/rlpx/buffer.go (254)
p2p/rlpx/rlpx_test.go (246)
p2p/rlpx/buffer_test.go (102)
rlp/raw.go (16)
‼️ # 22535 cmd/devp2p/internal/ethtest: add block hash announcement test 2/0/0
cmd/devp2p/internal/ethtest (2)
123/0
cmd/devp2p/internal/ethtest/helpers.go (206)
cmd/devp2p/internal/ethtest/suite.go (40)
# 22621 crypto/secp256k1: fix undefined behavior in BitCurve.Add 4/4/0
crypto/secp256k1 (5)
tests/fuzzers/secp256k1 (2)
oss-fuzz.sh (1)
143/42
crypto/secp256k1/scalar_mult_cgo.go (112)
crypto/secp256k1/curve.go (106)
tests/fuzzers/secp256k1/secp_fuzzer.go (100)
crypto/secp256k1/scalar_mult_nocgo.go (26)
tests/fuzzers/secp256k1/secp_test.go (16)
# 22943 p2p/msgrate: return capacity as integer 3/1/0
p2p/msgrate (2)
eth/downloader (1)
eth/protocols/snap (1)
79/41
eth/downloader/peer.go (96)
eth/protocols/snap/sync.go (60)
p2p/msgrate/msgrate_test.go (56)
p2p/msgrate/msgrate.go (28)
# 22940 cmd/puppeth: remove outdated mist support 4/0/2
cmd/puppeth (6)
5/398
cmd/puppeth/module_wallet.go (402)
cmd/puppeth/wizard_wallet.go (226)
cmd/puppeth/module_dashboard.go (128)
cmd/puppeth/wizard_network.go (18)
cmd/puppeth/wizard_dashboard.go (16)
‼️ # 22957 cmd/devp2p/internal/ethtest: ignore block announcement in tx test 1/0/0
cmd/devp2p/internal/ethtest (1)
10/1
cmd/devp2p/internal/ethtest/suite.go (22)
‼️ # 22898 EIP-1559 tx pool support 5/0/0
core (3)
core/types (1)
eth/gasprice (1)
743/143
core/tx_pool_test.go (1130)
core/tx_list.go (404)
core/tx_pool.go (116)
core/types/transaction.go (114)
eth/gasprice/gasprice.go (8)
‼️ # 22970 core: add new eip-1559 tx constraints 5/0/0
core (5)
102/12
core/state_processor_test.go (98)
core/state_transition.go (44)
core/tx_pool_test.go (40)
core/error.go (24)
core/tx_pool.go (22)
‼️ # 22972 cmd/geth, core, params: replace baikal with calaveras 11/0/0
cmd/geth (5)
core (3)
params (2)
cmd/utils (1)
49/49
cmd/utils/flags.go (60)
cmd/geth/dbcmd.go (32)
params/config.go (28)
core/genesis.go (24)
cmd/geth/main.go (12)
⚠️ # 22962 core/state: fix typos in test error message 1/0/0
core/state (1)
2/2
core/state/statedb_test.go (8)
# 22584 metrics: use golang.org/x/sys/unix to support Solaris 1/0/0
metrics (1)
1/1
metrics/cpu_syscall.go (4)
‼️ # 22964 1559 rpc 19/0/0
core/types (4)
internal/ethapi (3)
eth/gasprice (2)
graphql (2)
internal/jsre/deps (2)
eth/protocols/snap (1)
internal/web3ext (1)
les (1)
core (1)
eth (1)
eth/tracers (1)
411/160
internal/ethapi/transaction_args.go (244)
eth/gasprice/gasprice.go (198)
internal/jsre/deps/bindata.go (180)
internal/ethapi/api.go (168)
eth/gasprice/gasprice_test.go (138)
‼️ # 22973 eth/ethconfig: flip the default from fast to snap sync 1/0/0
eth/ethconfig (1)
1/1
eth/ethconfig/config.go (4)
⚠️ # 22988 cmd/faucet: disable flaky facebook test 1/0/0
cmd/faucet (1)
2/0
cmd/faucet/faucet_test.go (4)
‼️ # 22989 eth/catalyst: runs every transaction in a snapshot in assembleBlock handler 1/0/0
eth/catalyst (1)
2/0
eth/catalyst/api.go (4)
# 22930 miner/stress: add stress test for eip 1559 0/1/1
miner/stress/1559 (1)
miner/stress/clique (1)
256/0
miner/stress/1559/main.go (512)
‼️ # 22995 core, eth, miner: enforce configured mining reward post 1559 too 9/0/0
eth (4)
core (2)
core/types (1)
eth/catalyst (1)
miner (1)
39/12
core/tx_pool.go (58)
core/types/transaction.go (16)
core/tx_pool_test.go (4)
eth/api_backend.go (4)
eth/catalyst/api.go (4)
‼️ # 23001 trie/database.go remove the duplicate write for 'preimage' 1/0/0
trie (1)
0/6
trie/database.go (12)
‼️ # 22976 tests: update for London 11/0/0
tests (7)
core (3)
cmd/evm/internal/t8ntool (1)
130/44
tests/state_test_util.go (126)
tests/gen_sttransaction.go (88)
tests/block_test_util.go (40)
cmd/evm/internal/t8ntool/execution.go (30)
core/gen_genesis.go (16)
‼️ # 22982 go.mod: upgrade to fastcache v1.6.0 2/0/0
go.sum (1)
go.mod (1)
7/8
go.sum (22)
go.mod (8)
‼️ # 22978 core/rawdb: db inspect move 'config' and 'shutdown' into 'meta data' 1/0/0
core/rawdb (1)
4/6
core/rawdb/database.go (20)
‼️ # 23010 all: rename internal 1559 gas fields, add support for graphql 27/0/0
core/types (8)
core (7)
internal/ethapi (2)
eth/gasprice (2)
graphql (2)
interfaces.go (1)
miner/stress/1559 (1)
accounts/abi/bind/backends (1)
cmd/evm/testdata/10 (1)
cmd/evm/testdata/9 (1)
miner (1)
329/262
core/types/transaction.go (212)
internal/ethapi/transaction_args.go (172)
graphql/graphql.go (144)
core/state_transition.go (108)
core/tx_pool_test.go (48)
# 22966 cmd/clef, signer: support 1559 type transactions in clef 11/5/0
cmd/clef/testdata (5)
signer/core (5)
signer/fourbyte (2)
cmd/clef (1)
internal/ethapi (1)
signer/rules (1)
accounts/external (1)
177/58
signer/core/types.go (134)
signer/core/api.go (44)
accounts/external/backend.go (38)
cmd/clef/testdata/sign_1559_tx.json (34)
cmd/clef/testdata/sign_bad_checksum_exp_fail.json (34)
‼️ # 23028 eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25 1/0/0
eth/ethconfig (1)
1/1
eth/ethconfig/config.go (4)
# 23025 Rename unused function with typo 1/0/0
common (1)
2/2
common/debug.go (8)
⚠️ # 23027 core, internal: support various eth_call invocations post 1559 9/0/0
core/vm (4)
internal/ethapi (2)
internal/jsre/deps (2)
core (1)
62/51
core/state_transition.go (80)
core/vm/evm.go (76)
internal/ethapi/transaction_args.go (24)
core/vm/instructions_test.go (20)
internal/jsre/deps/bindata.go (12)
‼️ # 23013 core: make genesis parse baseFee correctly 2/0/0
core (2)
5/4
core/gen_genesis.go (16)
core/genesis.go (2)
⚠️ # 22624 accounts/abi/bind/backends: add simulated reorgs 2/0/0
accounts/abi/bind/backends (2)
241/34
accounts/abi/bind/backends/simulated_test.go (424)
accounts/abi/bind/backends/simulated.go (126)
‼️ # 23039 core: change baseFee into baseFeePerGas in genesis json 2/0/0
core (2)
3/3
core/gen_genesis.go (8)
core/genesis.go (4)
‼️ # 23041 params: add london testnet blocks 2/0/0
core/forkid (1)
params (1)
29/20
core/forkid/forkid_test.go (92)
params/config.go (6)
‼️ # 23038 accounts/abi/bind: fix bounded contracts and sim backend for 1559 30/0/0
core (9)
accounts/abi/bind (4)
accounts/abi/bind/backends (2)
consensus/clique (2)
eth/catalyst (2)
eth/downloader (2)
eth/tracers (2)
eth/filters (2)
ethclient (1)
contracts/checkpointoracle (1)
eth/fetcher (1)
eth/gasprice (1)
eth/protocols/eth (1)
371/181
core/blockchain_test.go (294)
accounts/abi/bind/base.go (164)
accounts/abi/bind/backends/simulated_test.go (162)
accounts/abi/bind/backends/simulated.go (84)
accounts/abi/bind/bind_test.go (72)
‼️ # 23051 params: bump CHTs for Geth v1.10.4 1/0/0
params (1)
12/12
params/config.go (48)
⚠️ # 23050 core, graphql, internal: expose effectiveGasPrice in receipts 7/0/0
internal/jsre/deps (2)
graphql (2)
core (1)
core/types (1)
internal/ethapi (1)
42/8
graphql/graphql.go (30)
internal/ethapi/api.go (24)
graphql/schema.go (14)
internal/jsre/deps/bindata.go (12)
core/types/transaction.go (8)
‼️ # 23047 core/vm: evm fix panic 2/0/0
core/vm/runtime (2)
6/1
core/vm/runtime/runtime.go (12)
core/vm/runtime/env.go (2)
‼️ # 23055 core: readded state processor error tests 1/0/0
core (1)
1/1
core/state_processor_test.go (4)
‼️ # 23060 travis, build: own docker builder and hub pusher 2/0/0
.travis.yml (1)
build (1)
83/0
build/ci.go (104)
.travis.yml (62)
# 23061 travis: don't overwrite amd64 images with arm64 1/0/0
.travis.yml (1)
0/16
.travis.yml (32)

264 Changed files

🔍 File Lines Changed Linked PR
‼️ cmd/devp2p/internal/ethtest/suite.go 1742 # 22843
# 22535
# 22957
cmd/devp2p/internal/ethtest/helpers.go 1476 # 22843
# 22535
‼️ core/tx_pool_test.go 1174 # 22995
# 22898
# 23010
# 22970
cmd/devp2p/internal/ethtest/eth66_suite.go 1042 # 22843
p2p/msgrate/msgrate.go 932 # 22876
# 22943
p2p/rlpx/rlpx.go 770 # 22899
‼️ internal/ethapi/api.go 692 # 22718
# 22942
# 23027
# 23010
# 22964
# 23050
cmd/devp2p/internal/ethtest/eth66_suiteHelpers.go 666 # 22843
‼️ eth/protocols/snap/sync.go 662 # 22876
# 22943
‼️ core/blockchain_test.go 626 # 22888
# 22822
# 22733
# 22837
# 23010
# 23038
‼️ cmd/devp2p/internal/ethtest/transaction.go 596 # 22843
⚠️ accounts/abi/bind/backends/simulated_test.go 582 # 22624
# 23038
internal/ethapi/transaction_args.go 562 # 22718
# 23027
# 22966
# 23010
# 22964
‼️ core/state_processor_test.go 514 # 22888
# 22896
# 23010
# 22970
# 23055
miner/stress/1559/main.go 512 # 22930
# 23010
‼️ cmd/devp2p/internal/ethtest/types.go 476 # 22843
‼️ eth/downloader/peer.go 422 # 22876
# 22943
‼️ core/vm/operations_acl.go 420 # 22733
‼️ core/tx_list.go 404 # 22898
# 23010
cmd/puppeth/module_wallet.go 402 # 22940
‼️ core/types/transaction.go 316 # 22896
# 22995
# 22898
# 23010
# 22964
# 23050
consensus/misc/eip1559_test.go 266 # 22837
‼️ eth/gasprice/gasprice.go 256 # 22752
# 22898
# 23010
# 22964
p2p/rlpx/buffer.go 254 # 22899
‼️ core/types/receipt_test.go 246 # 22852
‼️ eth/downloader/downloader.go 238 # 22876
‼️ graphql/graphql.go 236 # 22718
# 22942
# 23010
# 22964
# 23050
‼️ cmd/geth/chaincmd.go 228 # 22795
# 22822
# 22972
cmd/puppeth/wizard_wallet.go 226 # 22940
‼️ accounts/abi/bind/backends/simulated.go 214 # 22837
# 23010
# 22624
# 23038
core/types/dynamic_fee_tx.go 208 # 23010
‼️ core/types/receipt.go 196 # 22852
‼️ cmd/geth/snapshot.go 194 # 22795
consensus/misc/eip1559.go 186 # 22837
‼️ internal/jsre/deps/bindata.go 180 # 23027
# 22964
# 23050
‼️ core/types/transaction_marshalling.go 180 # 23010
# 22964
‼️ core/tx_pool.go 172 # 22933
# 22995
# 22898
# 23010
# 22970
# 23050
‼️ accounts/abi/bind/base.go 164 # 23038
‼️ core/state/dump.go 160 # 22795
‼️ core/types/transaction_signing.go 158 # 22822
# 23010
cmd/evm/testdata/10/readme.md 158 # 22837
cmd/evm/testdata/9/readme.md 150 # 22837
‼️ core/state_transition.go 150 # 22733
# 23027
# 23010
# 22970
‼️ eth/gasprice/gasprice_test.go 142 # 23010
# 22964
# 23038
cmd/evm/testdata/10/txs.json 140 # 22837
# 23010
ethstats/ethstats_test.go 134 # 21640
‼️ core/types/block_test.go 130 # 23010
‼️ cmd/utils/flags.go 128 # 22795
# 22822
# 22752
# 22900
# 22949
# 22972
cmd/puppeth/module_dashboard.go 128 # 22940
‼️ core/types/transaction_test.go 126 # 22896
# 23010
‼️ eth/handler_eth_test.go 118 # 22908
crypto/secp256k1/scalar_mult_cgo.go 112 # 22621
‼️ build/ci.go 108 # 22848
# 23060
eth/downloader/peer_test.go 106 # 22876
crypto/secp256k1/curve.go 106 # 22621
p2p/rlpx/buffer_test.go 102 # 22899
‼️ core/forkid/forkid_test.go 100 # 22879
# 23041
core/vm/eips.go 92 # 22733
‼️ core/vm/evm.go 88 # 22809
# 23027
consensus/misc/gaslimit.go 84 # 22837
‼️ core/genesis.go 82 # 22780
# 22822
# 22837
# 22976
# 22972
# 23013
# 23039
# 23038
‼️ ethstats/ethstats.go 82 # 22952
# 21640
⚠️ core/types/log.go 78 # 22852
cmd/evm/testdata/9/txs.json 74 # 22837
# 23010
‼️ consensus/ethash/consensus.go 74 # 22840
# 22870
# 22837
‼️ accounts/abi/bind/bind_test.go 72 # 23038
‼️ core/block_validator.go 72 # 22896
⚠️ core/block_validator_test.go 66 # 22896
‼️ cmd/evm/internal/t8ntool/transition.go 66 # 22795
# 22871
# 22837
⚠️ consensus/clique/clique.go 62 # 22836
# 22837
‼️ accounts/external/backend.go 62 # 22837
# 22966
‼️ miner/worker.go 60 # 22896
# 22995
# 23010
‼️ eth/tracers/api_test.go 60 # 22718
# 23038
p2p/msgrate/msgrate_test.go 56 # 22943
‼️ light/odr_test.go 54
‼️ core/state/snapshot/generate_test.go 52 # 22944
‼️ build/checksums.txt 52 # 22848
‼️ miner/worker_test.go 52 # 22896
cmd/evm/testdata/11/alloc.json 50 # 22837
p2p/discover/v4wire/v4wire_test.go 48 # 22842
‼️ eth/tracers/tracer.go 48 # 22857
les/protocol.go 48 # 22841
‼️ eth/protocols/eth/protocol.go 48 # 22841
‼️ ethclient/ethclient_test.go 48
‼️ cmd/evm/internal/t8ntool/execution.go 46 # 22837
# 22976
p2p/discover/v4wire/v4wire.go 46 # 22842
cmd/evm/poststate.json 46 # 22837
eth/api_test.go 46 # 22795
cmd/evm/testdata/10/alloc.json 46 # 22837
⚠️ accounts/abi/bind/backend.go 44 # 23038
cmd/evm/internal/t8ntool/gen_stenv.go 44 # 22837
‼️ graphql/schema.go 40 # 23010
# 22964
# 23050
‼️ les/test_helper.go 40
cmd/devp2p/internal/ethtest/chain.go 40 # 22843
‼️ eth/ethconfig/config.go 40 # 22822
# 22752
# 22973
# 23028
‼️ core/state/state_test.go 38 # 22795
‼️ core/chain_makers.go 38 # 22837
# 22896
# 22964
# 23038
‼️ eth/api.go 38 # 22795
‼️ eth/catalyst/api.go 36 # 22896
# 22995
# 22989
# 23038
⚠️ accounts/abi/bind/util_test.go 36 # 23038
‼️ eth/protocols/snap/sync_test.go 36 # 22876
⚠️ internal/jsre/deps/web3.js 36 # 23027
# 22964
# 23050
cmd/clef/testdata/sign_1559_tx.json 34 # 22966
⚠️ eth/protocols/snap/range.go 34 # 22851
‼️ eth/tracers/api.go 34 # 22718
# 22964
# 23038
cmd/clef/testdata/sign_normal_exp_ok.json 34 # 22966
‼️ eth/handler.go 34 # 22908
# 22995
cmd/clef/testdata/sign_bad_checksum_exp_fail.json 34 # 22966
‼️ core/rawdb/database.go 32 # 22878
# 22978
‼️ cmd/geth/dbcmd.go 32 # 22822
# 22972
cmd/clef/testdata/sign_1559_missing_maxfeepergas_exp_fail.json 32 # 22966
‼️ core/error.go 32 # 22837
# 23010
# 22970
‼️ p2p/peer.go 32 # 22908
cmd/clef/testdata/sign_1559_missing_field_exp_fail.json 32 # 22966
.travis.yml 30 # 23060
# 23061
p2p/dnsdisc/client_test.go 30 # 22906
‼️ interfaces.go 28 # 23010
‼️ eth/protocols/eth/handler_test.go 28 # 23038
‼️ core/types/block.go 28 # 22964
‼️ core/vm/instructions_test.go 28 # 22745
# 23027
cmd/evm/testdata/11/txs.json 28 # 22837
‼️ eth/tracers/tracer_test.go 28 # 22857
cmd/evm/testdata/11/readme.md 26 # 22837
‼️ go.sum 26 # 22745
# 22982
crypto/secp256k1/scalar_mult_nocgo.go 26 # 22621
cmd/evm/testdata/11/env.json 24 # 22837
cmd/evm/testdata/10/env.json 24 # 22837
cmd/evm/testdata/9/alloc.json 22 # 22837
⚠️ light/txpool_test.go 22
‼️ core/evm.go 20 # 22837
‼️ core/vm/jump_table.go 20 # 22733
cmd/evm/staterunner.go 20 # 22795
‼️ ethclient/ethclient.go 20 # 23038
‼️ cmd/geth/main.go 18 # 22822
# 22752
# 22972
p2p/discover/v4_udp.go 18 # 22842
‼️ graphql/graphql_test.go 18
cmd/puppeth/wizard_network.go 18 # 22940
les/retrieve.go 18 # 22921
‼️ eth/catalyst/api_test.go 18 # 23038
p2p/discover/v4_udp_test.go 16 # 22842
cmd/puppeth/wizard_dashboard.go 16 # 22940
cmd/puppeth/wizard_netstats.go 16 # 22940
contracts/checkpointoracle/oracle_test.go 16 # 23038
‼️ les/odr_test.go 16
cmd/evm/testdata/9/env.json 16 # 22837
core/gen_genesis.go 16 # 22976
# 23013
# 23039
‼️ eth/filters/filter_test.go 16 # 23038
miner/stress/ethash/main.go 14 # 22919
‼️ les/client_handler.go 14 # 22921
⚠️ p2p/nat/natupnp_test.go 14 # 22877
‼️ cmd/geth/consolecmd.go 12 # 22822
# 22844
# 22972
‼️ p2p/dnsdisc/client.go 12 # 22906
⚠️ light/trie_test.go 12
‼️ cmd/clef/main.go 12 # 22966
⚠️ consensus/ethash/difficulty.go 12 # 22745
‼️ core/state_processor.go 12 # 22837
‼️ core/vm/runtime/runtime.go 12 # 22822
# 23047
‼️ eth/fetcher/block_fetcher_test.go 12 # 23038
core/types/gen_header_json.go 12 # 22964
‼️ eth/api_backend.go 12 # 22995
# 22964
‼️ go.mod 12 # 22745
# 22982
⚠️ consensus/clique/clique_test.go 10 # 23038
‼️ les/odr.go 10 # 22921
‼️ core/vm/logger_json.go 10 # 22825
‼️ internal/web3ext/web3ext.go 10 # 22964
miner/stress/clique/main.go 10 # 22930
‼️ core/genesis_test.go 8 # 22822
# 22972
common/debug.go 8 # 23025
‼️ les/api_backend.go 8 # 22964
core/rlp_test.go 8 # 23038
core/rawdb/table.go 8 # 22911
eth/downloader/statesync.go 8 # 22876
eth/downloader/testchain_test.go 8 # 23038
eth/downloader/queue_test.go 8 # 23038
‼️ eth/tracers/tracers_test.go 8
core/asm/lex_test.go 8 # 22883
‼️ core/vm/logger_test.go 8 # 22745
⚠️ core/state/statedb_test.go 8 # 22962
‼️ cmd/puppeth/wizard_genesis.go 8 # 22822
‼️ cmd/geth/config.go 8 # 22822
les/txrelay.go 6 # 22921
‼️ core/types/legacy_tx.go 6 # 23010
‼️ core/headerchain_test.go 6 # 23038
‼️ core/rawdb/freezer.go 6 # 22878
‼️ cmd/geth/usage.go 6 # 22822
# 22752
# 22972
‼️ core/types/access_list_tx.go 6 # 23010
‼️ core/blockchain_snapshot_test.go 6 # 23038
‼️ core/vm/interpreter.go 6 # 22733
# 23027
core/vm/opcodes.go 6
‼️ eth/backend.go 4 # 22822
⚠️ consensus/clique/snapshot_test.go 4 # 23038
‼️ eth/filters/filter_system_test.go 4 # 23038
⚠️ core/dao_test.go 4 # 23038
‼️ core/state/statedb.go 4 # 22822
crypto/secp256k1/panic_cb.go 4 # 22621
les/fetcher.go 4 # 22921
core/gen_genesis_account.go 4 # 22976
‼️ eth/protocols/snap/range_test.go 4 # 22964
les/handler_test.go 4
‼️ eth/handler_test.go 4 # 22995
crypto/secp256k1/secp256.go 4 # 22621
‼️ eth/sync.go 4 # 22995
‼️ les/client.go 4 # 22822
⚠️ cmd/faucet/faucet_test.go 4 # 22988
‼️ cmd/geth/genesis_test.go 4 # 22949
‼️ core/state_prefetcher.go 4 # 22837
‼️ eth/state_accessor.go 4
‼️ internal/ethapi/backend.go 4 # 22964
⚠️ core/blockchain_sethead_test.go 4 # 23038
⚠️ core/forkid/forkid.go 4 # 22879
⚠️ core/blockchain_repair_test.go 4 # 23038
‼️ core/bench_test.go 4 # 22896
‼️ core/vm/instructions.go 4 # 23027
‼️ les/state_accessor.go 4
core/asm/lexer.go 4 # 22883
cmd/evm/runner.go 4 # 22795
‼️ core/genesis_alloc.go 4 # 22822
# 22972
metrics/cpu_syscall.go 4 # 22584
‼️ core/vm/errors.go 2 # 22809
‼️ oss-fuzz.sh 2 # 22621
‼️ core/vm/runtime/env.go 2 # 23047
tests/init_test.go 0 # 22941
‼️ params/version.go 0
rlp/encode_test.go 0 # 22832
# 22902
# 22927
# 22924
‼️ signer/core/types.go 0 # 22966
⚠️ tests/transaction_test.go 0 # 22941
⚠️ signer/core/api_test.go 0 # 22966
tests/difficulty_test.go 0 # 22941
‼️ tests/state_test_util.go 0 # 22976
tests/fuzzers/secp256k1/secp_fuzzer.go 0 # 22621
tests/rlp_test.go 0 # 22941
signer/core/gnosis_safe.go 0 # 22966
tests/gen_btheader.go 0 # 22976
rlp/safe.go 0 # 22937
# 22924
‼️ tests/init.go 0 # 22822
‼️ rlp/unsafe.go 0 # 22924
```` 0 # 22919
‼️ tests/testdata 0 # 22976
signer/core/cliui.go 0 # 22966
rlp/raw.go 0 # 22899
signer/rules/rules_test.go 0 # 22966
tests/vm_test.go 0 # 22941
⚠️ tests/block_test_util.go 0 # 22976
rlp/raw_test.go 0 # 22899
tests/fuzzers/secp256k1/secp_test.go 0 # 22621
tests/state_test.go 0 # 22941
rlp/decode_test.go 0 # 22832
# 22927
# 22924
‼️ params/config.go 0 # 22822
# 22972
# 23051
# 23041
‼️ signer/core/api.go 0 # 22966
signer/fourbyte/validation.go 0 # 22966
‼️ params/protocol_params.go 0 # 22733
tests/gen_stenv.go 0 # 22976
‼️ params/bootnodes.go 0 # 22822
# 22972
p2p/transport.go 0 # 22899
‼️ tests/block_test.go 0 # 22941
# 22976
p2p/rlpx/rlpx_test.go 0 # 22899
rlp/doc.go 0 # 22832
‼️ tests/gen_sttransaction.go 0 # 22976
signer/fourbyte/validation_test.go 0 # 22966
⚠️ tests/fuzzers/bls12381/bls12381_fuzz.go 0 # 22937
rlp/typecache.go 0 # 22832
# 22902
rlp/encode.go 0 # 22832
# 22902
# 22924
‼️ trie/database.go 0 # 23001
rlp/decode.go 0 # 22832
# 22902
# 22927
# 22924
# 22858

MrChico and others added 30 commits March 22, 2021 09:29
* accounts: eip-712 signing for ledger

* address review comments
* all: add read-only option to database

* all: fixes tests

* cmd/geth: migrate flags

* cmd/geth: fix the compact

* cmd/geth: fix the format

* cmd/geth: fix log

* cmd: add chain-readonly

* core: add readonly notion to freezer

* core/rawdb: add log

* core/rawdb: fix freezer close

* cmd: fix

* cmd, core: construct db

* core: update tests
Check the input parameters against the actual head block, exit on error
core/state/snapshot: fix panic on missing parent
eth/protocols/snap, eth/downloader: don't use bloom filter in snap sync
…(#22461)

* internal/web3ext,node: migrate node admin API (Start|Stop)RPC->HTTP

Corresponding CLI flags --rpc have been moved to --http.

This moves the admin module HTTP RPC start/stop
methods to an equivalent namespace.

Rel ethereum/go-ethereum#22263

Date: 2021-03-08 08:00:11-06:00
Signed-off-by: meows <b5c6@protonmail.com>

* internal/web3ext: fix startRPC/HTTP param count (4->5)

Date: 2021-03-16 06:13:23-05:00
Signed-off-by: meows <b5c6@protonmail.com>
In Geth v1.10, we changed the structure of the "les" ENR entry. As a result, the DHT crawler that creates the DNS lists
no longer recognizes the les nodes, which is fixed in this commit. 

* cmd/devp2p: skip ENR field tails properly in nodeset filter
* cmd/devp2p: fix tail decoder for snap as well
* les: fix tail decoding in "eth" ENR entry
This makes the rate limit apply regardless of whether the node is
already cached.
* eth/protocols/snap: fix snap sync

* eth/protocols/snap: fix tests

* eth: fix tiny

* eth: update tests

* eth: update tests

* core/state/snapshot: testcase for #22534

* eth/protocols/snap: fix boundary loss on full-but-proven range

* core/state/snapshot: lintfix

* eth: address comment

* eth: fix handler

Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Péter Szilágyi <peterke@gmail.com>
…pturestart (#22333)

Fixes the CaptureStart api to include the EVM, thus being able to set the statedb early on. This pr also exposes the struct we used internally in the interpreter to encapsulate the contract, mem, stack, rstack, so we pass it as a single struct to the tracer, and removes the error returns on the capture methods.
* cmd/devp2p: fix comparison of TXT record value

The AWS API returns quoted DNS strings, so we must encode the new value
before comparing it against the existing record content.

* cmd/devp2p: add test

* cmd/devp2p: fix typo and rename val -> newValue
core: fix condition on header verification
eth/protocols, metrics, p2p: add handler performance metrics
eth/protocols, metrics: use resetting histograms for rare packets
This avoids synchronisation failures when the local header is ahead of
the local full block.
…(#22558)

The PR implements the --miner.notify.full flag that enables full pending block
notifications. When this flag is used, the block notifications sent to mining
endpoints contain the complete block header JSON instead of a work package
array.

Co-authored-by: AlexSSD7 <alexandersadovskyi7@protonmail.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
metrics/influxdb: don't push empty histograms, no measurement != 0
eth/protocols/snap: add peer id and req id to the timeout logs
This upgrades the cloudflare client dependency to v0.14.0. The new
version changes the API because all methods now require a context
parameter. This change also reduces the log level of the 'Skipping...'
message to debug, following a similar change in the AWS deployer.
…#22579)

The main idea behind it is: the range compaction is very expensive
which can take a few hours to finish. During this long procedure,
a lot of exceptions can occur, e.g.
- Geth is killed manually
- Geth is killed because of machine crash
- etc

In order to minimize the effect of the exceptions, the compaction
is moved out of the pruning. So that even the compaction is not
finished, the pruning is regarded as done.
holiman and others added 28 commits June 7, 2021 14:37
This updates the tests submodule to the London fork tests, and
also updates the test runner to support the new EIP-1559 fields in
test JSON.
…(#22978)

* core/rawdb: db inspect move 'config' and 'shutdown' into 'meta data'

* gofmt
* all: rename internal 1559 gas fields, add support for graphql

* cmd/evm/testdata, core: use public 1559 gas names on API surfaces
eth/ethconfig: bump the RPC gas cap to 50M, since 1559 exceeds 25
This function is not used in the code base, so probably safe to do rename, or remove in its entirety, but I'm assuming the logic from the original creator still applies so rename probably better.
core, internal: support various eth_call invocations post 1559
core: make genesis parse baseFee correctly
* accounts/abi/bind/backends: add blockByHashNoLock

Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>

* accounts/abi/bind/backends: add 'parent' arg to rollback

Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>

* accounts/abi/bind/backends: add simulated forks

Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>

* accounts/abi/bind/backends: minor nitpicks

* accounts/abi/bind/backends: don't add defensive panics

Co-authored-by: Péter Szilágyi <peterke@gmail.com>
core: change baseFee into baseFeePerGas in genesis json
* params: add london testnet blocks

* core/forkid: update fork hashes
…3038)

* accounts/abi/bind: fix bounded contracts and sim backend for 1559

* accounts/abi/bind, ethclient: don't rely on chain config for gas prices

* all: enable London for all internal tests

* les: get receipt type info in les tests

* les: fix weird test

Co-authored-by: Martin Holst Swende <martin@swende.se>
params: bump CHTs for Geth v1.10.4
core, graphql, internal: expose effectiveGasPrice in receipts
* core/vm: evm fix panic

* core/vm/runtime: default to params.initialbasefee
travis, build: own docker builder and hub pusher
travis: don't overwrite amd64 images with arm64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
geth upstream upgrade Have some Geth upgrade to process
Projects
None yet
Development

Successfully merging this pull request may close these issues.