-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chained_prs): add description on chained PRs #70
Conversation
ba9e8cd
to
9b3e4a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part of the documentation needs to differentiate between two topics in development:
- Chained PRs themselves that are a way to issue multiple PRs, on which one PRs depends on the other.
- WIP branches development process, which is a way to, for a large contribution, provide separate PRs that are reviews and merged separately for a temporary WIP branch, and that will later be merged to main based on a separate PR.
As an alternative, you could issue separate PRs for each one.
7f17ed6
to
a7a9136
Compare
I just self-contained this PR on the description of chain of PRs and created a new one #73 to explain the process of splitting large PRs. |
a7a9136
to
3e7c401
Compare
3e7c401
to
0d45f30
Compare
23be74c
to
f80547a
Compare
Please rebase the branch with main |
The merge-base changed after approval.
b68d958
to
4b66440
Compare
Signed-off-by: Daniel Oliveira <drawnpoetry@gmail.com>
4b66440
to
d17eac1
Compare
Done. |
PR Description
This PR introduces to the contributing guidelines a description on when and why to use a chain of PRs.
Type of change
Checklist: