Skip to content
This repository has been archived by the owner on Mar 2, 2023. It is now read-only.

Deep forked the repository #5

Merged
merged 15 commits into from
May 20, 2021
Merged

Deep forked the repository #5

merged 15 commits into from
May 20, 2021

Conversation

pregnor
Copy link
Member

@pregnor pregnor commented May 20, 2021

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Deep forked the repository.

Highlights:

  • License: MIT -> Apache 2.0.
  • Updated GolangCI-Lint 1.40.1 configuration.
  • Refactored Makefile.
  • Refactored container.
  • Refactored plugin install.
  • Refactored end to end tests (Minio -> LocalStack or directly AWS after confirmation).
  • Refactored GoReleaser (archive, binary, checksum, amd64, arm64, darwin, linux).
  • Refactored CI (CircleCI -> GitHub Actions).

See the individual commits for more details.

Why?

We cannot wait for upstream to merge the dynamic bucket region feature, but the plugin also requires a version tag, this was the best way to ensure functionality and proceed with the Helm S3 repositories.

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

pregnor added 14 commits May 20, 2021 01:03
Need to deep fork the repository, because we
cannot wait any more for our dynamic bucket region
feature PR to be merged.

License: MIT -> Apache 2.0

To avoid licensing issues.

Removed repository logo asset to avoid infringing
intellectual property rights.
Updated repository "self" references.
Run Codium's Rewrap extension to format the files.
https://github.com/stkb/Rewrap
Updated dependency references before modifying
files.
Run golangci-lint --fix on the repo.
Removed unnecessary ignores.
Updated/simplified/personalized build tasks.
Updated/simplified/personalized container related
files.
Updated/simplified/personalized plugin install.
Changed the end to end tests' Minio S3 API
provider to AWS and LocalStack providers to
support both local and remote end to end testing
out of the box.

AWS works with a regular AWS account with an
access to the S3 service.
(Tested.)

LocalStack works with no additional requirements
than the LocalStack container.
(Tested.)

Also refactored the tests (assert->require,
testify/suite, linter fixes).
@pregnor pregnor self-assigned this May 20, 2021
@pregnor pregnor force-pushed the chore/fork branch 4 times, most recently from 5c58070 to 00ee1f7 Compare May 20, 2021 11:24
@pregnor pregnor merged commit 907c8fb into main May 20, 2021
@pregnor pregnor deleted the chore/fork branch May 20, 2021 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant