This repository has been archived by the owner on Mar 2, 2023. It is now read-only.
forked from hypnoglow/helm-s3
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to deep fork the repository, because we cannot wait any more for our dynamic bucket region feature PR to be merged. License: MIT -> Apache 2.0 To avoid licensing issues. Removed repository logo asset to avoid infringing intellectual property rights.
Updated repository "self" references.
Run Codium's Rewrap extension to format the files. https://github.com/stkb/Rewrap
Updated dependency references before modifying files.
Personalized linting.
Run golangci-lint --fix on the repo.
Removed unnecessary ignores.
Not necessary anymore.
Updated/simplified/personalized build tasks.
Updated/simplified/personalized container related files.
Updated/simplified/personalized plugin install.
Changed the end to end tests' Minio S3 API provider to AWS and LocalStack providers to support both local and remote end to end testing out of the box. AWS works with a regular AWS account with an access to the S3 service. (Tested.) LocalStack works with no additional requirements than the LocalStack container. (Tested.) Also refactored the tests (assert->require, testify/suite, linter fixes).
5c58070
to
00ee1f7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Deep forked the repository.
Highlights:
See the individual commits for more details.
Why?
We cannot wait for upstream to merge the dynamic bucket region feature, but the plugin also requires a version tag, this was the best way to ensure functionality and proceed with the Helm S3 repositories.
Checklist
Related Helm chart(s) updated (if needed)