Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added affinity templating to dex #1071

Merged
merged 3 commits into from
Mar 24, 2020
Merged

Added affinity templating to dex #1071

merged 3 commits into from
Mar 24, 2020

Conversation

bartlett-ops
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets no
License Apache 2.0

What's in this PR?

Templates affinity into the dex chart. Allows users to define affinity set in values.yml

Why?

This is useful for HA etc, it allows me to spread pods across multiple AZs in AWS. Affinity gives more granular control than nodeSelector

Checklist

  • Error handling code meets the guideline
  • Logging code meets the guideline (TODO)
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@bonifaido bonifaido self-assigned this Mar 24, 2020
bonifaido
bonifaido approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@bonifaido bonifaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @bartlettt , can you please bump the chart version, so we can tag a release after the merge?

@bartlett-ops
Copy link
Contributor Author

@bonifaido done

@bonifaido bonifaido added the dex label Mar 24, 2020
@bonifaido bonifaido requested a review from sagikazarmark March 24, 2020 13:27
@bonifaido bonifaido merged commit 9036c70 into banzaicloud:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonifaido bonifaido bonifaido approved these changes

@sagikazarmark sagikazarmark sagikazarmark approved these changes

@kozmagabor kozmagabor Awaiting requested review from kozmagabor

@pbalogh-sa pbalogh-sa Awaiting requested review from pbalogh-sa

Assignees

@bonifaido bonifaido

Labels
dex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartlett-ops @bonifaido @sagikazarmark