Various issues and data sources for resources. #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nareshkakubal
commented
Aug 25, 2023
- Error check if resource with same name exist in banyan console before create is executed. (Policy, Role, Service)
- Data Sources for Policy and Role. (add data sources for policies and roles #138)
- Allow_Pattern for rdp service.
- Ability to set empty value for client_banyanproxy_listen_port so endusers can have ability to get random port.
* add data sources for policies and roles * stop create policy clobbering * documentation fixup * Prevent new roles from clobbering existing roles * Force new roles and policies if name changes to align with api --------- Co-authored-by: Jordan Yerkes <jyerkes@strikingdistancestudios.com>
yoshiotu
reviewed
Aug 25, 2023
yoshiotu
reviewed
Aug 25, 2023
yoshiotu
reviewed
Aug 25, 2023
yerkulees
reviewed
Aug 25, 2023
yoshiotu
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.