Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.0 버전 배포 #247

Merged
merged 110 commits into from
Oct 4, 2022
Merged
Changes from 1 commit
Commits
Show all changes
110 commits
Select commit Hold shift + click to select a range
fe87281
refactor: refresh request body로 변경 #221
ozzing Sep 11, 2022
6cd8492
chore: rT cookie set 함수 주석 처리 #221
ozzing Sep 11, 2022
029a406
refactor: 주석 처리 및 테스트 코드 수정 #221
ozzing Sep 11, 2022
f3af303
Merge pull request #222 from bankidz/feature/aTrefresh
ozzing Sep 11, 2022
3a3bd00
refactor: 유저 타입 선택 API #223
ozzing Sep 11, 2022
c7d9ab2
refactor: 유저 타입 선택 test #223
ozzing Sep 11, 2022
83b834c
refactor: 유저 로그아웃 API #223
ozzing Sep 11, 2022
95b4f09
del: cookie set #223
ozzing Sep 11, 2022
b60462f
refactor: 유저 엑스포 토큰 등록 API #223
ozzing Sep 11, 2022
866b1a4
chore: uRepo to userRepository #223
ozzing Sep 11, 2022
3f9042c
refactor: jwt decode username에서 id로 변경 #223
ozzing Sep 11, 2022
4b60172
refactor: 토큰 리프레시 jwt 관련 test #223
ozzing Sep 11, 2022
e88b270
refactor: 토큰 리프레시 API #223
ozzing Sep 11, 2022
3fbac38
refactor: 토큰 리프레시 API test #223
ozzing Sep 11, 2022
ccf70e8
refactor: 카카오, 애플 로그인 및 테스트 #223
ozzing Sep 11, 2022
b5af5f9
Merge pull request #224 from bankidz/refactor/userController
ozzing Sep 12, 2022
b8d9bf3
refactor: 헤더로 aT 획득 #225
ozzing Sep 12, 2022
6c58935
del: tokenRequest 삭제 #225
ozzing Sep 12, 2022
002fd6d
refactor: refresh aT 테스트 코드 변경 #225
ozzing Sep 12, 2022
155aca8
Merge pull request #226 from bankidz/refactor/refresh
ozzing Sep 12, 2022
43ecbe6
refactor: 가족 생성하기 API #227
ozzing Sep 12, 2022
c6d88a5
refactor: 가족 생성하기 test #227
ozzing Sep 12, 2022
bb38f30
chore: 코드 스타일 통일 #227
ozzing Sep 12, 2022
859a456
refactor: 가족 나가기 API #227
ozzing Sep 12, 2022
9bbc40d
refactor: 가족 나가기 test #227
ozzing Sep 12, 2022
4d8f707
refactor: 가족 참여하기 API #227
ozzing Sep 12, 2022
8525889
refactor: 가족 참여하기 test #227
ozzing Sep 12, 2022
8e53c80
refactor: 가족 참여하기 test #227
ozzing Sep 12, 2022
bc5ab1f
refactor: 아이들 목록 조회하기 #227
ozzing Sep 12, 2022
e9f483b
refactor: 아이들 목록 조회하기 test #227
ozzing Sep 12, 2022
f839082
refactor: 가족 정보 조회하기 API #227
ozzing Sep 12, 2022
ec31336
refactor: family controller 리팩 완료 #227
ozzing Sep 12, 2022
aec8075
refactor: family controller 리팩에 의한 test 리팩 완료 #227
ozzing Sep 12, 2022
fc810e1
refactor: 유저 탈퇴 API 가족 나가기 #227
ozzing Sep 12, 2022
28cbdd0
refactor: 유저 탈퇴 test #227
ozzing Sep 12, 2022
24ce150
refactor: transactional readOnly 재설정 #227
ozzing Sep 12, 2022
6b1b210
refactor: 소셜 로그인 재사용성 고려 리팩 #227
ozzing Sep 12, 2022
e892614
chore: 오타 수정 #227
ozzing Sep 12, 2022
dc0bbdb
refactor: 돈길 생성 API 레이어 구조 리팩토링 #229
sanbonai06 Sep 13, 2022
2ca29c4
refactor: 돈길 삭제 API 구조 리팩토링 #229
sanbonai06 Sep 13, 2022
3638f64
Merge pull request #228 from bankidz/refactor/familyController
ozzing Sep 13, 2022
fc6944f
chore: cors, refresh auth 설정 변경
ozzing Sep 14, 2022
c074e2c
refactor: 돈길 삭제하기 API row 삭제순서 수정 및 돈길 리스트 API 리팩토링 초안 #229
sanbonai06 Sep 14, 2022
5da24ff
refactor: 돈길 리스트 가져오기 API에 연동되는 알림 / 레벨업까지 전부 리팩 #229
sanbonai06 Sep 14, 2022
5ed0615
fix: 돈길 리스트 쿼리파라미터 검사 로직 수정 #229
sanbonai06 Sep 15, 2022
8534b51
fix: timestamp json format hh -> kk 로 수정 #229
sanbonai06 Sep 15, 2022
183dc8a
refactor: 자녀 돈길리스트 가져오기 API 리팩토링 #229
sanbonai06 Sep 16, 2022
7f08a8e
refactor: 돈길 수락 / 거절 API 리팩토링 #229
sanbonai06 Sep 16, 2022
2b355ff
refactor: 주차정보 / 자녀의 주차 정보 API 리팩토링 #229
sanbonai06 Sep 16, 2022
28862c0
refactor: 완주한 돈길 리스트 가져오기 / 자녀의 완주한 돈길 리스트 가져오기 리팩토링 #229
sanbonai06 Sep 16, 2022
74c33d5
refactor: 돈길 걷기 API 리팩토링 #229
sanbonai06 Sep 16, 2022
f3840ea
Merge branch 'dev' into refactor/challengeController
sanbonai06 Sep 16, 2022
7afe9bd
Merge pull request #230 from bankidz/refactor/challengeController
sanbonai06 Sep 16, 2022
20617a1
fix: 병합 충돌 해결 및 swagger DTO 명명 영어로 변경
sanbonai06 Sep 16, 2022
ecc65c1
refactor: 가족 나가기 API 돈길 부분 리팩토링 작업 #229
sanbonai06 Sep 18, 2022
00d479a
refactor: 가족 나가기 및 유저 탈퇴 돈길 쪽 로직들 리팩토링 #229
sanbonai06 Sep 18, 2022
3b78dd7
refactor: 돈길 걷기 API 리팩토링 완료 #299
sanbonai06 Sep 18, 2022
7d44b75
fix: jpa 문법 수정 #229
sanbonai06 Sep 18, 2022
41059a2
refactor: 돈길 관련 API들 리팩토링 완료 및 swagger 테스트 완료 #229
sanbonai06 Sep 18, 2022
2fefa7a
Merge pull request #231 from bankidz/refactor/challengeController
sanbonai06 Sep 18, 2022
510c8c8
refactor: 컨트롤러 패키지 명을 mapper로 변경
sanbonai06 Sep 19, 2022
04ad05e
refactor: 새 컨트롤러 패키지 생성
sanbonai06 Sep 19, 2022
03ca19f
refactor: 돈길 생성 API Mapper 레이어 생성하여 리팩토링 #232
sanbonai06 Sep 19, 2022
90e90fb
refactor: 돈길 삭제 API Mapper 구조로 리팩토링 #232
sanbonai06 Sep 19, 2022
1781302
refactor: 돈길 리스트 API Mapper 구조로 리팩토링 #232
sanbonai06 Sep 19, 2022
087eece
refactor: 주차 정보 API Mapper 구조로 리팩토링 #232
sanbonai06 Sep 19, 2022
7b1742a
refactor: 완주한 돈길 리스트 API Mapper 구조로 리팩토링 #232
sanbonai06 Sep 19, 2022
e6cabdc
refactor: 이자 지급 API Mapper 구조로 리팩토링 #232
sanbonai06 Sep 19, 2022
e86b66c
refactor: 돈길 걷기 API Mapper 구조로 리팩토링 #232
sanbonai06 Sep 19, 2022
13ab209
refactor: 일요일 밸리데이션 처리 추가 #232
sanbonai06 Sep 19, 2022
b765761
feat: 돈길 만든지 1주일 경과 전이면 삭제 조건 검사 안함 #232
sanbonai06 Sep 20, 2022
f430aee
refactor: challengeUser에 cascade가 달림에 따라 challengeUser 삭제 로직 제거 #232
sanbonai06 Sep 20, 2022
d3fc80e
refactor: Transactional 처리 #232
sanbonai06 Sep 20, 2022
a248296
Merge pull request #233 from bankidz/refactor/facadePattern
sanbonai06 Sep 20, 2022
df84864
refactor: 알림 서비스 구조 계층화 #234
sanbonai06 Sep 21, 2022
c60b7d9
refactor: 알림 관련 API 및 로직 리팩토링 #234
sanbonai06 Sep 21, 2022
e975efc
refactor: NotificationMapper 추가 #234
sanbonai06 Sep 21, 2022
214355f
refactor: challengeService / challengeMapper 사용 메서드 명명 규칙 통일 #234
sanbonai06 Sep 21, 2022
899e513
refactor: challengeUserService 사용 메서드 명명 규칙 통일 #234
sanbonai06 Sep 21, 2022
611f550
refactor: 자녀의 돈길 리스트 가져오기 API에서 거절당한 돈길은 보여주지 않기 #234
sanbonai06 Sep 23, 2022
3b9590a
Merge pull request #235 from bankidz/refactor/notificationMapper
ozzing Sep 24, 2022
fc8e0cd
refactor: 탈퇴 제외 controller-mapper-service 분리 및 메소드명 리네이밍 #236
ozzing Sep 24, 2022
bceeee5
fix: 유저 탈퇴 부분 제외 conflict 해결 #236
ozzing Sep 24, 2022
2181342
refactor: 유저 탈퇴 제외 user refactor 완료 #236
ozzing Sep 24, 2022
a678cdc
refactor: apple controller-mapper 분리, 메소드명 리네이밍 #236
ozzing Sep 24, 2022
d24d15a
refactor: kakao controller-mapper 분리, 메소드명 리네이밍 #236
ozzing Sep 24, 2022
4b9a6b0
refactor: kakao, apple controller test #236
ozzing Sep 24, 2022
cfe94c6
refactor: request 폴더 controller 밑으로 이동 #236
ozzing Sep 25, 2022
42c543c
Merge pull request #237 from bankidz/refactor/userMapper
ozzing Sep 26, 2022
e009e91
refactor: mapper - controller 분리 #238
ozzing Sep 26, 2022
72d7a14
refactor: mapper - service 정리 #238
ozzing Sep 26, 2022
76aaecd
refactor: 유저 탈퇴, 가족 나가기 api 매퍼 리팩토링 #239
ozzing Sep 26, 2022
bd247fa
refactor: 유저 탈퇴, 가족 나가기 api 매퍼 리팩토링 #238
ozzing Sep 26, 2022
363336f
Merge remote-tracking branch 'origin/refactor/familyMapper' into refa…
ozzing Sep 26, 2022
c55f4a6
refactor: mapper 레이어 crud로 메소드명 통일 #238
ozzing Sep 26, 2022
9f93bbd
refactor: service 레이어 직관적으로 메소드명 통일 #238
ozzing Sep 26, 2022
3de094b
Merge pull request #240 from bankidz/refactor/familyMapper
ozzing Sep 26, 2022
68bde7f
del: mapper에서 request mapping 제거
ozzing Sep 26, 2022
54dbfe5
fix: annotation 오타 수정
ozzing Sep 26, 2022
2fabb3b
refactor: user controller test 정상 작동 #241
ozzing Sep 26, 2022
efb0b32
refactor: family controller test 정상 작동 #241
ozzing Sep 26, 2022
cd72ab0
refactor: 가족 나가기 test #241
ozzing Sep 26, 2022
6c07b92
Merge pull request #242 from bankidz/refactor/userAndFamilyTest
ozzing Sep 27, 2022
5bbd8e0
refactor: 돈길 관련 테스트코드 초안 잡아놓기 #243
sanbonai06 Sep 28, 2022
58e533f
fix: s3 controller 파일 경로 수정 #243
sanbonai06 Sep 29, 2022
b00dd59
fix: 완주한 돈길 리스트 API 쿼리 스트링 문법 수정 #243
sanbonai06 Sep 29, 2022
7e0b93e
Merge pull request #244 from bankidz/feature/challengeTestCode
sanbonai06 Sep 29, 2022
3198ef5
refactor: 가족 조회 시 가족 없어도 빈 값 리턴 #245
ozzing Sep 29, 2022
ba8c079
refactor: 가족 없을 때 test 변경 #245
ozzing Sep 29, 2022
108f299
Merge pull request #246 from bankidz/refactor/readFamily
ozzing Sep 29, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: 자녀 돈길리스트 가져오기 API 리팩토링 #229
  • Loading branch information
sanbonai06 committed Sep 16, 2022
commit 183dc8af9bdeda97ea9aafc668095e0f3d23ef59
68 changes: 54 additions & 14 deletions src/main/java/com/ceos/bankids/controller/ChallengeController.java
Original file line number Diff line number Diff line change
@@ -7,13 +7,15 @@
import com.ceos.bankids.controller.request.KidChallengeRequest;
import com.ceos.bankids.domain.Challenge;
import com.ceos.bankids.domain.ChallengeUser;
import com.ceos.bankids.domain.Kid;
import com.ceos.bankids.domain.User;
import com.ceos.bankids.dto.AchievedChallengeDTO;
import com.ceos.bankids.dto.AchievedChallengeListDTO;
import com.ceos.bankids.dto.ChallengeDTO;
import com.ceos.bankids.dto.ChallengeListMapperDTO;
import com.ceos.bankids.dto.ChallengePostDTO;
import com.ceos.bankids.dto.KidAchievedChallengeListDTO;
import com.ceos.bankids.dto.KidChallengeListDTO;
import com.ceos.bankids.dto.KidWeekDTO;
import com.ceos.bankids.dto.WeekDTO;
import com.ceos.bankids.exception.BadRequestException;
@@ -176,20 +178,58 @@ public CommonResponse<List<ChallengeDTO>> getListChallenge(

return CommonResponse.onSuccess(challengeDTOList);
}
//
// @ApiOperation(value = "자녀의 돈길 리스트 가져오기")
// @GetMapping(value = "/kid/{kidId}", produces = "application/json; charset=utf-8")
// public CommonResponse<KidChallengeListDTO> getListKidChallenge(
// @AuthenticationPrincipal User authUser, @PathVariable Long kidId,
// @RequestParam String status) {
//
// log.info("api = 자녀의 돈길 리스트 가져오기, user = {}, kidId = {}, status = {}",
// authUser.getUsername(), kidId, status);
// KidChallengeListDTO kidChallengeList = challengeService.readKidChallenge(authUser, kidId,
// status);
//
// return CommonResponse.onSuccess(kidChallengeList);
// }

@ApiOperation(value = "자녀의 돈길 리스트 가져오기")
@GetMapping(value = "/kid/{kidId}", produces = "application/json; charset=utf-8")
public CommonResponse<KidChallengeListDTO> getListKidChallenge(
@AuthenticationPrincipal User authUser, @PathVariable Long kidId,
@RequestParam String status) {

log.info("api = 자녀의 돈길 리스트 가져오기, user = {}, kidId = {}, status = {}",
authUser.getUsername(), kidId, status);
Kid kid = kidService.getKid(kidId);
User kidUser = kid.getUser();
List<ChallengeDTO> challengeDTOList = new ArrayList<>();
List<Challenge> challengeList = challengeUserService.getChallengeUserList(kidUser,
status);
if (Objects.equals(status, "walking")) {
challengeList.forEach(challenge -> {
ChallengeListMapperDTO challengeListMapperDTO = challengeService.readWalkingChallenge(
challenge);
if (challengeListMapperDTO.getChangeStatus()
&& challenge.getChallengeStatus() == ChallengeStatus.ACHIEVED) {
notificationService.challengeAchievedNotification(challenge.getContractUser(),
challenge.getChallengeUser());
kidService.userLevelUp(challenge.getContractUser(),
authUser);
} else if (challengeListMapperDTO.getChangeStatus()
&& challenge.getChallengeStatus() == ChallengeStatus.FAILED) {
notificationService.challengeFailedNotification(challenge.getContractUser(),
challenge.getChallengeUser());
}
if (challenge.getChallengeStatus() != ChallengeStatus.ACHIEVED) {
ChallengeDTO challengeDTO = new ChallengeDTO(
challengeListMapperDTO.getChallenge(),
challengeListMapperDTO.getProgressDTOList(), null);
challengeDTOList.add(challengeDTO);
}
});
} else if (Objects.equals(status, "pending")) {
challengeList.forEach(challenge -> {
if (challenge.getContractUser().getId() == authUser.getId()) {
ChallengeListMapperDTO challengeListMapperDTO = challengeService.readPendingChallenge(
challenge);
ChallengeDTO challengeDTO = new ChallengeDTO(
challengeListMapperDTO.getChallenge(),
null, challenge.getComment());
challengeDTOList.add(challengeDTO);
}
});
}
KidChallengeListDTO kidChallengeListDTO = new KidChallengeListDTO(kidUser,
challengeDTOList);
return CommonResponse.onSuccess(kidChallengeListDTO);
}

@ApiOperation(value = "자녀의 돈길 수락 / 거절")
@PatchMapping(value = "/{challengeId}", produces = "application/json; charset=utf-8")
5 changes: 0 additions & 5 deletions src/main/java/com/ceos/bankids/service/ChallengeService.java
Original file line number Diff line number Diff line change
@@ -26,11 +26,6 @@ public interface ChallengeService {

public ChallengeDTO deletePendingChallenge(User user, ChallengeUser challengeUser);

// public List<ChallengeDTO> readChallengeList(User user, List<Challenge> challengeList,
// String status);

// public KidChallengeListDTO readKidChallenge(User user, Long kidId, String status);

public ChallengeDTO updateChallengeStatus(User user, Long challengeId,
KidChallengeRequest kidChallengeRequest) throws IOException;

10 changes: 0 additions & 10 deletions src/main/java/com/ceos/bankids/service/ChallengeServiceImpl.java
Original file line number Diff line number Diff line change
@@ -169,17 +169,7 @@ public ChallengeListMapperDTO readWalkingChallenge(Challenge challenge) {
return new ChallengeListMapperDTO(challenge, progressDTOList, true);
} else if (diffWeeks > challenge.getWeeks()) {
challenge.setChallengeStatus(achieved);
// Long userLevel = userLevelUp(kid.getAchievedChallenge() + 1);
// kid.setAchievedChallenge(kid.getAchievedChallenge() + 1);
// if (!Objects.equals(userLevel, kid.getLevel())) {
// notificationController.kidLevelUpNotification(
// challenge.getContractUser(), user, kid.getLevel(), userLevel);
// kid.setLevel(userLevel);
// }
challengeRepository.save(challenge);
// kidRepository.save(kid);
// notificationController.achieveChallengeNotification(
// challenge.getContractUser(), r);
return new ChallengeListMapperDTO(challenge, progressDTOList, true);
}
return new ChallengeListMapperDTO(challenge, progressDTOList, false);
3 changes: 3 additions & 0 deletions src/main/java/com/ceos/bankids/service/KidService.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.ceos.bankids.service;

import com.ceos.bankids.domain.Kid;
import com.ceos.bankids.domain.User;
import org.springframework.stereotype.Service;

@@ -14,4 +15,6 @@ public interface KidService {

public void userLevelUp(User contractUser, User user);

public Kid getKid(Long kidId);

}
7 changes: 7 additions & 0 deletions src/main/java/com/ceos/bankids/service/KidServiceImpl.java
Original file line number Diff line number Diff line change
@@ -117,4 +117,11 @@ public void userLevelUp(User contractUser, User user) {

}

@Transactional(readOnly = true)
@Override
public Kid getKid(Long kidId) {
return kidRepository.findById(kidId)
.orElseThrow(() -> new BadRequestException(ErrorCode.NOT_EXIST_KID.getErrorCode()));
}

}