Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refresh API aT 사용하는 것으로 변경 #222

Merged
merged 3 commits into from
Sep 11, 2022
Merged

feat: refresh API aT 사용하는 것으로 변경 #222

merged 3 commits into from
Sep 11, 2022

Conversation

ozzing
Copy link
Member

@ozzing ozzing commented Sep 11, 2022

📝 PR Summary

  • 쿠키를 사용하지 않도록 바뀐 로그인 로직에 맞추어 API 수정했습니다.
  • 이후 쿠키를 다시 사용할 것을 고려해 쿠키 굽는 함수 호출은 주석 처리했습니다.
  • 테스트 코드 작성했습니다.

🌲 Working Branch

feature/aTrefresh

🌲 TODOs

  • refresh API 수정
  • 기존 코드에서 사용하지 않는 부분 주석 처리
  • 테스트 코드 작성

Related Issues

#221

@ozzing ozzing added For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가 Type: Test [이슈 목적] 테스트 코드 추가, 수정 labels Sep 11, 2022
@ozzing ozzing added this to the 서비스 안정화 (v1.1.0) milestone Sep 11, 2022
@ozzing ozzing requested a review from sanbonai06 September 11, 2022 16:00
@ozzing ozzing self-assigned this Sep 11, 2022
sanbonai06
sanbonai06 approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@sanbonai06 sanbonai06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당

@ozzing ozzing merged commit f3af303 into dev Sep 11, 2022
@ozzing ozzing deleted the feature/aTrefresh branch September 11, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbonai06 sanbonai06 sanbonai06 approved these changes

Assignees

@ozzing ozzing

Labels
For: API [이슈 대상] 외부 API Type: Feature [이슈 목적] 새로운 기능 추가 Type: Test [이슈 목적] 테스트 코드 추가, 수정
Projects
None yet
Milestone
서비스 안정화 (v1.1.0)
Development

Successfully merging this pull request may close these issues.
2 participants
@ozzing @sanbonai06