Merge pull request #263 from bankidz/refactor/birthday

refactor: 미가입 생년월일 빈 문자열 대신 99999999로 변경
bankidz · Nov 2, 2022 · 7e4cba4 · 7e4cba4
2 parents 3584924 + e5374d3
commit 7e4cba4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/com/ceos/bankids/mapper/UserMapper.java b/src/main/java/com/ceos/bankids/mapper/UserMapper.java
@@ -68,7 +68,7 @@ public UserDTO updateUserType(User user, UserTypeRequest userTypeRequest) {
         }
 
         // 날짜가 입력됐다면 유효한지 검사
-        if (userTypeRequest.getBirthday() != "") {
+        if (userTypeRequest.getBirthday() != "99999999") {
             SimpleDateFormat dateFormat = new SimpleDateFormat("yyyyMMdd");
             dateFormat.setLenient(false);
             try {

diff --git a/src/test/java/com/ceos/bankids/unit/controller/UserControllerTest.java b/src/test/java/com/ceos/bankids/unit/controller/UserControllerTest.java
@@ -123,7 +123,7 @@ public void testIfUserTypePatchWithoutBirthdaySucceedReturnResult() {
             .provider("kakao")
             .refreshToken("token")
             .build();
-        UserTypeRequest userTypeRequest = new UserTypeRequest("", false, true);
+        UserTypeRequest userTypeRequest = new UserTypeRequest("99999999", false, true);
         UserRepository mockUserRepository = Mockito.mock(UserRepository.class);
         Mockito.when(mockUserRepository.findById(1L))
             .thenReturn(Optional.ofNullable(user));
@@ -163,7 +163,7 @@ public void testIfUserTypePatchWithoutBirthdaySucceedReturnResult() {
         CommonResponse<UserDTO> result = userController.patchUserType(user, userTypeRequest);
 
         // then
-        user.setBirthday("");
+        user.setBirthday("99999999");
         user.setIsFemale(false);
         user.setIsKid(true);
         UserDTO userDTO = new UserDTO(user);