chore: use hashicorp/vault image as _/vault is deprecated #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@becker-s thank you for the contribution! Would you mind updating other references of the image as well? There is a couple: https://github.com/search?q=repo%3Abank-vaults%2Fvault-secrets-webhook%20vault%3A&type=code Also, can you please sign off your commits (you can do it by passing Thanks! |
Hashicorp has deprecated Duplicative Docker Images (see https://developer.hashicorp.com/vault/docs/v1.13.x/deprecation). New versions of vault are only published to https://hub.docker.com/hashicorp/vault. https://hub.docker.com/_/vault only contains old versions up to 1.13.3. Signed-off-by: Simon Becker <135833417+becker-s@users.noreply.github.com>
Signed-off-by: Simon Becker <135833417+becker-s@users.noreply.github.com>
|
@sagikazarmark sure, I updated my commits to include the other image references. |
|
@becker-s appreciate it, thanks! |
JonTheNiceGuy
pushed a commit
to JonTheNiceGuy/vault-secrets-webhook
that referenced
this pull request
Sep 20, 2023
chore: use hashicorp/vault image as _/vault is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hashicorp has deprecated Duplicative Docker Images (see https://developer.hashicorp.com/vault/docs/v1.13.x/deprecation).
New versions of vault are only published to https://hub.docker.com/hashicorp/vault.
https://hub.docker.com/_/vault only contains old versions up to 1.13.3.
Notes for reviewer
When this commit is merged, the vault version should be updated to the latest version.