Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vault-log-level overwritten in pods #327

Merged
merged 6 commits into from
Feb 22, 2024
Merged

fix: vault-log-level overwritten in pods #327

merged 6 commits into from
Feb 22, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Feb 7, 2024 •
edited
Loading

Overview

  • Wrote a test to showcase the problem mentioned in the issue.
  • Added a check, if VAULT_LOG_LEVEL is set in the container, it remains unchanged after mutation. However, if it isn't, and the vaultConfig contains the relevant field, the value is set accordingly.

Fixes #290

@csatib02 csatib02 requested a review from a team as a code owner February 7, 2024 13:55
@csatib02 csatib02 requested review from akijakya and removed request for a team February 7, 2024 13:55
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-499 lines label Feb 7, 2024
ramizpolic
ramizpolic reviewed Feb 12, 2024
View reviewed changes
pkg/webhook/pod.go Outdated Show resolved Hide resolved
csatib02 and others added 6 commits February 12, 2024 11:56
@csatib02
fix(pod.go): failing test for #290
ef62baa 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02
fix(pod.go) issue fix
6047c15 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02
fix(pod.go): minor fix
73f66c6 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02
fix(pod.go): minor fix
edfa851 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@ramizpolic @csatib02
fix: simplify log check
aeaea7d 
Signed-off-by: Bence Csati <csatib02@gmail.com>
@csatib02
chore: comment
87f4d7e 
Signed-off-by: Bence Csati <bcsati@cisco.com>
akijakya
akijakya approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@akijakya akijakya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ramizpolic
ramizpolic approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ramizpolic ramizpolic merged commit f08d331 into bank-vaults:main Feb 22, 2024
21 checks passed
@csatib02 csatib02 deleted the fix/log-level-overwritten-in-pods branch February 22, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akijakya akijakya akijakya approved these changes

@ramizpolic ramizpolic ramizpolic approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webhook: VAULT_LOG_LEVEL overwritten in Pods
3 participants
@csatib02 @ramizpolic @akijakya