-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: extend documentation #216
Conversation
b2eaa18
to
7b4201c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments about obsolete stuff that can be fixed in a next step, otherwise LGTM, thanks!
I just noticed a thing: there is a Another thing is that updating the chart readme could be added to the pre-commit hooks, so it would refresh automatically when a something is changed around the chart, what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I fiddled with it, I found some issues I previously overlooked...
Signed-off-by: Ramiz Polić <ramiz.polic@hotmail.com>
Signed-off-by: Ramiz Polić <ramiz.polic@hotmail.com>
Signed-off-by: Ramiz Polić <ramiz.polic@hotmail.com>
Signed-off-by: Ramiz Polic <ramiz.polic@hotmail.com> Signed-off-by: Ramiz Polić <ramiz.polic@hotmail.com>
Signed-off-by: Ramiz Polic <ramiz.polic@hotmail.com> Signed-off-by: Ramiz Polić <ramiz.polic@hotmail.com>
Signed-off-by: Ramiz Polić <ramiz.polic@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* docs: add helm chart docs Signed-off-by: Ramiz Polić <ramiz.polic@hotmail.com> * docs: add OpenSSF Best Practices badge Signed-off-by: Ramiz Polić <ramiz.polic@hotmail.com> * docs: update helm chart readme Signed-off-by: Ramiz Polić <ramiz.polic@hotmail.com> * feat: update helm docs Signed-off-by: Ramiz Polic <ramiz.polic@hotmail.com> Signed-off-by: Ramiz Polić <ramiz.polic@hotmail.com> * fix: helm installation guide Signed-off-by: Ramiz Polic <ramiz.polic@hotmail.com> Signed-off-by: Ramiz Polić <ramiz.polic@hotmail.com> * docs: fix helm readme template Signed-off-by: Ramiz Polić <ramiz.polic@hotmail.com> --------- Signed-off-by: Ramiz Polić <ramiz.polic@hotmail.com> Signed-off-by: Ramiz Polic <ramiz.polic@hotmail.com>
Overview
This PR adds/fixes helm docs and adds OpenSSF Best Practice badge to the repo readme.
Fixes #206 #18
Notes for reviewer