Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e test, readme improvements #191

Merged
merged 3 commits into from
Sep 26, 2023
Merged

e2e test, readme improvements #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9cfbb7d
chore: remove vim filetype comment
akijakya Sep 22, 2023
b49694c
fix(docs): operator -> webhook in readme
akijakya Sep 22, 2023
a1b1bb2
test: replace deprecated functions in e2e suite
akijakya Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

## Documentation

The official documentation for the operator is available at [https://bank-vaults.dev](https://bank-vaults.dev/docs/operator/).
The official documentation for the webhook is available at [https://bank-vaults.dev](https://bank-vaults.dev/docs/mutating-webhook/).

## Development

Expand Down
1 change: 0 additions & 1 deletion deploy/charts/vault-secrets-webhook/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{{/* vim: set filetype=mustache: */}}
{{/*
Expand the name of the chart.
*/}}
Expand Down
9 changes: 6 additions & 3 deletions e2e/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import (
"sigs.k8s.io/e2e-framework/pkg/env"
"sigs.k8s.io/e2e-framework/pkg/envconf"
"sigs.k8s.io/e2e-framework/pkg/envfuncs"
"sigs.k8s.io/e2e-framework/support/kind"
"sigs.k8s.io/e2e-framework/third_party/helm"
)

Expand Down Expand Up @@ -77,13 +78,15 @@ func TestMain(m *testing.M) {
} else {
clusterName := envconf.RandomName("vault-secrets-webhook-test", 32)

kindCluster := kind.NewProvider()
if v := os.Getenv("KIND_K8S_VERSION"); v != "" {
testenv.Setup(envfuncs.CreateKindClusterWithConfig(clusterName, "kindest/node:"+v, "kind.yaml"))
kindCluster.WithOpts(kind.WithImage("kindest/node:" + v))
testenv.Setup(envfuncs.CreateClusterWithConfig(kindCluster, clusterName, "kind.yaml"))
} else {
testenv.Setup(envfuncs.CreateKindCluster(clusterName))
testenv.Setup(envfuncs.CreateCluster(kindCluster, clusterName))
}

testenv.Finish(envfuncs.DestroyKindCluster(clusterName))
testenv.Finish(envfuncs.DestroyCluster(clusterName))

if image := os.Getenv("LOAD_IMAGE"); image != "" {
testenv.Setup(envfuncs.LoadDockerImageToCluster(clusterName, image))
Expand Down